Skip to content

Commit 737038d

Browse files
isasmendiagussschuberth
authored andcommitted
fix(scanoss)!: Remove unused version properties
* Remove regScannerName property as it is not being used. * Remove minVersion and maxVersion properties as these are not effectively used for compatibility checking. * The KB in SCANOSS updates regularly, making version-based compatibility difficult to maintain in practice. * Version information from SCANOSS responses could be captured directly in the future if needed. Signed-off-by: Agustin Isasmendi <agustin.isasmendi@scanoss.com>
1 parent 9810f5e commit 737038d

File tree

2 files changed

+0
-23
lines changed

2 files changed

+0
-23
lines changed

plugins/scanners/scanoss/src/main/kotlin/ScanOssConfig.kt

Lines changed: 0 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -33,21 +33,6 @@ data class ScanOssConfig(
3333
@OrtPluginOption(defaultValue = "")
3434
val apiKey: Secret,
3535

36-
/**
37-
* A regular expression to match the scanner name when looking up scan results in the storage.
38-
*/
39-
val regScannerName: String?,
40-
41-
/**
42-
* The minimum version of stored scan results to use.
43-
*/
44-
val minVersion: String?,
45-
46-
/**
47-
* The maximum version of stored scan results to use.
48-
*/
49-
val maxVersion: String?,
50-
5136
/**
5237
* Whether to write scan results to the storage.
5338
*/

plugins/scanners/scanoss/src/test/kotlin/TestUtils.kt

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -42,19 +42,11 @@ internal fun createScanOss(config: ScanOssConfig): ScanOss = ScanOss(config = co
4242
internal fun createScanOssConfig(
4343
apiUrl: String = ScanApi.DEFAULT_BASE_URL,
4444
apiKey: Secret = Secret(""),
45-
regScannerName: String? = null,
46-
minVersion: String? = null,
47-
maxVersion: String? = null,
48-
readFromStorage: Boolean = true,
4945
writeToStorage: Boolean = true
5046
): ScanOssConfig =
5147
ScanOssConfig(
5248
apiUrl = apiUrl,
5349
apiKey = apiKey,
54-
regScannerName = regScannerName,
55-
minVersion = minVersion,
56-
maxVersion = maxVersion,
57-
readFromStorage = readFromStorage,
5850
writeToStorage = writeToStorage
5951
)
6052

0 commit comments

Comments
 (0)