-
Notifications
You must be signed in to change notification settings - Fork 505
Description
Prerequisites
- [ X] Put an X between the brackets on this line if you have done all of the following:
- Reproduced the problem in a new virtualenv with only neuralprophet installed, directly from github:
git clone <copied link from github> cd neural_prophet pip install .
- Checked the Answered Questions on the Github Discussion board: https://github.com/ourownstory/neural_prophet/discussions
If you have the same question but the Answer does not solve your issue, please continue the conversation there. - Checked that your issue isn't already filed: https://github.com/ourownstory/neural_prophet/issues
If you have the same issue but there is a twist to your situation, please add an explanation there. - Considered whether your bug might actually be solvable by getting a question answered:
- Please post a package use question
- Please post a forecasting best practice question
- Please post an idea or feedback
- Reproduced the problem in a new virtualenv with only neuralprophet installed, directly from github:
Describe the bug
I'm refering to this tutorial: https://neuralprophet.com/how-to-guides/feature-guides/collect_predictions.html
-
In chapter "Predictions based on forecast start" where you describe the parameter .predict(raw=True) you're saying "step0 is the prediction for this datetime. step1 is the prediction for the next datetime." which is correct. But in the corresponding example below you describe the dataframe with "Note that the last row contains the last possible forecast, forecasting 1961-1-01, 1961-2-01 and 1961-3-01 with data available at 1960-12-01." and this is wrong because step0 is in fact the prediction for ds=1960-12-01.
-
In Chapter "Predictions sorted based on forecast target" your example table contains columns called "residualx" but this is not the case for everyone who follow the step and just executes the code in this tutorial.
To Reproduce
Steps to reproduce the behavior:
Just run exaclty the the code documented in this chapter and you can reproduce it easily -> it's outputs don't reflect the documentation.
Expected behavior
- Step0 is the forecast for 1960-12-01, step1 is the forecast for 1961-1-01 and step2 is the forecast for 1961-2-01
- Just a table without the columns called "residual1", "residual2" and so on.
Describe what happens, and how often it happens.
Screenshots
If applicable, add screenshots and console printouts to help explain your problem.
Environment (please complete the following information):
- Python environment [e.g. Python 3.8, in standalone venv with no other packages]
- NeuralProphet version and install method [e.g. 2.7, installed from PYPI with
pip install neuralprophet
]
Additional context
Add any other context about the problem here.