Skip to content

Commit d8deb7c

Browse files
committed
feat: add edit space image option in bottom sheet dialog for space manager users
1 parent 7398da5 commit d8deb7c

File tree

5 files changed

+11
-1
lines changed

5 files changed

+11
-1
lines changed

owncloudApp/src/main/java/com/owncloud/android/extensions/SpaceMenuOptionExt.kt

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -26,6 +26,7 @@ import com.owncloud.android.domain.spaces.model.SpaceMenuOption
2626
fun SpaceMenuOption.toStringResId() =
2727
when (this) {
2828
SpaceMenuOption.EDIT -> R.string.edit_space
29+
SpaceMenuOption.EDIT_IMAGE -> R.string.edit_space_image
2930
SpaceMenuOption.DISABLE -> R.string.disable_space
3031
SpaceMenuOption.ENABLE -> R.string.enable_space
3132
SpaceMenuOption.DELETE -> R.string.delete_space
@@ -34,6 +35,7 @@ fun SpaceMenuOption.toStringResId() =
3435
fun SpaceMenuOption.toDrawableResId() =
3536
when (this) {
3637
SpaceMenuOption.EDIT -> R.drawable.ic_pencil
38+
SpaceMenuOption.EDIT_IMAGE -> R.drawable.file_image
3739
SpaceMenuOption.DISABLE -> R.drawable.ic_disable_space
3840
SpaceMenuOption.ENABLE -> R.drawable.ic_enable_space
3941
SpaceMenuOption.DELETE -> R.drawable.ic_action_delete_white

owncloudApp/src/main/java/com/owncloud/android/presentation/spaces/SpacesListFragment.kt

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -382,6 +382,7 @@ class SpacesListFragment :
382382
negativeButtonText = getString(R.string.common_no)
383383
)
384384
}
385+
SpaceMenuOption.EDIT_IMAGE -> { }
385386
}
386387
}
387388
}

owncloudApp/src/main/res/values/strings.xml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -849,6 +849,7 @@
849849
<string name="create_space_correctly">Space created correctly</string>
850850
<string name="create_space_failed">Space could not be created</string>
851851
<string name="edit_space">Edit space</string>
852+
<string name="edit_space_image">Edit space image</string>
852853
<string name="edit_space_correctly">Space updated correctly</string>
853854
<string name="edit_space_failed">Space could not be updated</string>
854855
<string name="disable_space">Disable space</string>

owncloudDomain/src/main/java/com/owncloud/android/domain/spaces/model/SpaceMenuOption.kt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,5 +21,5 @@
2121
package com.owncloud.android.domain.spaces.model
2222

2323
enum class SpaceMenuOption {
24-
EDIT, DISABLE, ENABLE, DELETE
24+
EDIT, EDIT_IMAGE, DISABLE, ENABLE, DELETE
2525
}

owncloudDomain/src/main/java/com/owncloud/android/domain/spaces/usecases/FilterSpaceMenuOptionsUseCase.kt

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -43,10 +43,16 @@ class FilterSpaceMenuOptionsUseCase(
4343
val deletePermission =
4444
(UserPermissions.CAN_DELETE_SPACES in params.userPermissions || hasSpacePermission(spacePermissionsResult, DRIVES_DELETE_PERMISSION))
4545

46+
val editImagePermission = hasSpacePermission(spacePermissionsResult, DRIVES_MANAGE_PERMISSION)
47+
4648
if (editPermission || isSpaceManager) {
4749
optionsToShow.add(SpaceMenuOption.EDIT)
4850
}
4951

52+
if (editImagePermission) {
53+
optionsToShow.add(SpaceMenuOption.EDIT_IMAGE)
54+
}
55+
5056
if (!currentSpace.isDisabled && deletePermission) {
5157
optionsToShow.add(SpaceMenuOption.DISABLE)
5258
}

0 commit comments

Comments
 (0)