Skip to content

pypi: correct examples and tests for "file_name" NOT "filename" #649

@pombredanne

Description

@pombredanne

@sethmlarson reported this on matrix:

So it looks like the "file name" qualifier for PyPI PURLs isn't defined right. The definition says file_name and the examples are all filename, so... anyone know which it actually is? 🙈

To which I replied:

That's a bug that should have been clarified. It is correct in the main type definition, but the examples and tests are incorrect!
See

"key": "file_name",

^ is correct
"pkg:pypi/django@1.11.1?filename=Django-1.11.1.tar.gz",
... in incorrect in examples

and also in tests
https://github.com/package-url/purl-spec/blob/main/tests/types/pypi-test.json#L99

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions