-
-
Notifications
You must be signed in to change notification settings - Fork 354
Open
Description
When contributing to pact-js, a user will submit a pull request, which will trigger several jobs.
Some of these jobs will fail, as the forked repository does not have access to repository secrets, this is a sensible and preferred approach to security, however it does leave us in a predicament when it comes to accepting contributions.
As some of the jobs will always fail, the test completion check will always fail. This is a required status check, and pre-requisite for merging, with no current way to circumvent.
We should consider how we can support external contributor workflows
- Disable jobs which require publishing if external org is not
pact-foundation
- stops external contributors being able to test anything that touches a broker
- Disable publishing steps only for examples which do so
- stops external contributors being able to test anything that touches a broker
- Hard code PACT_BROKER_TOKEN secret and export to env, if external org is not
pact-foundation
- At least allows users/maintainers to test/confirm behaviour for anything that touches a broker
- On contributor workflows, only run publishing steps on linux machines and use docker based locally running pact-broker
- would allow test of basic_auth based flows which are unsupported by the PactFlow broker
Metadata
Metadata
Assignees
Labels
No labels