Skip to content

[contributing] - for forked pull requests, either support or disable pact broker publishing #1344

@YOU54F

Description

@YOU54F

When contributing to pact-js, a user will submit a pull request, which will trigger several jobs.

Some of these jobs will fail, as the forked repository does not have access to repository secrets, this is a sensible and preferred approach to security, however it does leave us in a predicament when it comes to accepting contributions.

As some of the jobs will always fail, the test completion check will always fail. This is a required status check, and pre-requisite for merging, with no current way to circumvent.

We should consider how we can support external contributor workflows

  1. Disable jobs which require publishing if external org is not pact-foundation
    • stops external contributors being able to test anything that touches a broker
  2. Disable publishing steps only for examples which do so
    • stops external contributors being able to test anything that touches a broker
  3. Hard code PACT_BROKER_TOKEN secret and export to env, if external org is not pact-foundation
    • At least allows users/maintainers to test/confirm behaviour for anything that touches a broker
  4. On contributor workflows, only run publishing steps on linux machines and use docker based locally running pact-broker
    • would allow test of basic_auth based flows which are unsupported by the PactFlow broker

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions