refactor: remove unused RefLine::road_id, avoid duplicated data, no behaviour tied to it

Author: pageldev

include/RefLine.h

@@ -13,7 +13,7 @@ namespace odr
 
 struct RefLine
 {
-    RefLine(std::string road_id, double length);
+    RefLine(double length);
     RefLine(const RefLine& other);
 
     std::set<const RoadGeometry*> get_geometries() const;
@@ -29,7 +29,6 @@ struct RefLine
     double           match(const double x, const double y) const;
     std::set<double> approximate_linear(const double eps, const double s_start, const double s_end) const;
 
-    std::string road_id = "";
     double      length = 0;
     CubicSpline elevation_profile;
 

src/RefLine.cpp

@@ -13,9 +13,9 @@
 
 namespace odr
 {
-RefLine::RefLine(std::string road_id, double length) : road_id(road_id), length(length) {}
+RefLine::RefLine(double length) : length(length) {}
 
-RefLine::RefLine(const RefLine& other) : road_id(other.road_id), length(other.length), elevation_profile(other.elevation_profile)
+RefLine::RefLine(const RefLine& other) : length(other.length), elevation_profile(other.elevation_profile)
 {
     for (const auto& s0_geometry : other.s0_to_geometry)
         this->s0_to_geometry.emplace(s0_geometry.first, s0_geometry.second->clone());

src/Road.cpp

@@ -65,7 +65,7 @@ std::vector<RoadSignal> Road::get_road_signals() const
 }
 
 Road::Road(std::string id, double length, std::string junction, std::string name, bool left_hand_traffic) :
-    length(length), id(id), junction(junction), name(name), left_hand_traffic(left_hand_traffic), ref_line(id, length)
+    length(length), id(id), junction(junction), name(name), left_hand_traffic(left_hand_traffic), ref_line(length)
 {
 }