refactor: remove redundant GeometryType from RoadGeometry, can use dynamic_cast to identify type

Author: pageldev

include/Geometries/RoadGeometry.h

@@ -7,17 +7,9 @@
 namespace odr
 {
 
-enum class GeometryType
-{
-    Line,
-    Spiral,
-    Arc,
-    ParamPoly3
-};
-
 struct RoadGeometry
 {
-    RoadGeometry(double s0, double x0, double y0, double hdg0, double length, GeometryType type);
+    RoadGeometry(double s0, double x0, double y0, double hdg0, double length);
     virtual ~RoadGeometry() = default;
 
     virtual std::unique_ptr<RoadGeometry> clone() const = 0;
@@ -27,12 +19,11 @@ struct RoadGeometry
 
     virtual std::set<double> approximate_linear(double eps) const = 0;
 
-    double       s0 = 0;
-    double       x0 = 0;
-    double       y0 = 0;
-    double       hdg0 = 0;
-    double       length = 0;
-    GeometryType type;
+    double s0 = 0;
+    double x0 = 0;
+    double y0 = 0;
+    double hdg0 = 0;
+    double length = 0;
 };
 
 } // namespace odr

src/Geometries/Arc.cpp

@@ -5,8 +5,7 @@
 
 namespace odr
 {
-Arc::Arc(double s0, double x0, double y0, double hdg0, double length, double curvature) :
-    RoadGeometry(s0, x0, y0, hdg0, length, GeometryType::Arc), curvature(curvature)
+Arc::Arc(double s0, double x0, double y0, double hdg0, double length, double curvature) : RoadGeometry(s0, x0, y0, hdg0, length), curvature(curvature)
 {
 }
 

src/Geometries/Line.cpp

@@ -7,7 +7,7 @@
 namespace odr
 {
 
-Line::Line(double s0, double x0, double y0, double hdg0, double length) : RoadGeometry(s0, x0, y0, hdg0, length, GeometryType::Line) {}
+Line::Line(double s0, double x0, double y0, double hdg0, double length) : RoadGeometry(s0, x0, y0, hdg0, length) {}
 
 std::unique_ptr<RoadGeometry> Line::clone() const
 {

src/Geometries/ParamPoly3.cpp

@@ -23,16 +23,7 @@ ParamPoly3::ParamPoly3(double s0,
                        double cV,
                        double dV,
                        bool   pRange_normalized) :
-    RoadGeometry(s0, x0, y0, hdg0, length, GeometryType::ParamPoly3),
-    aU(aU),
-    bU(bU),
-    cU(cU),
-    dU(dU),
-    aV(aV),
-    bV(bV),
-    cV(cV),
-    dV(dV),
-    pRange_normalized(pRange_normalized)
+    RoadGeometry(s0, x0, y0, hdg0, length), aU(aU), bU(bU), cU(cU), dU(dU), aV(aV), bV(bV), cV(cV), dV(dV), pRange_normalized(pRange_normalized)
 {
     if (!pRange_normalized)
     {

src/Geometries/RoadGeometry.cpp

@@ -3,9 +3,6 @@
 namespace odr
 {
 
-RoadGeometry::RoadGeometry(double s0, double x0, double y0, double hdg0, double length, GeometryType type) :
-    s0(s0), x0(x0), y0(y0), hdg0(hdg0), length(length), type(type)
-{
-}
+RoadGeometry::RoadGeometry(double s0, double x0, double y0, double hdg0, double length) : s0(s0), x0(x0), y0(y0), hdg0(hdg0), length(length) {}
 
 } // namespace odr

src/Geometries/Spiral.cpp

@@ -9,7 +9,7 @@ namespace odr
 {
 
 Spiral::Spiral(double s0, double x0, double y0, double hdg0, double length, double curv_start, double curv_end) :
-    RoadGeometry(s0, x0, y0, hdg0, length, GeometryType::Spiral), curv_start(curv_start), curv_end(curv_end)
+    RoadGeometry(s0, x0, y0, hdg0, length), curv_start(curv_start), curv_end(curv_end)
 {
     this->c_dot = (curv_end - curv_start) / length;
     this->s_start = curv_start / c_dot;