ci: use clang 14 in windows runner and update format-files.sh to require clang-format version >= 13 and < 18

Author: pageldev

.github/workflows/ci.yaml

@@ -31,6 +31,10 @@ jobs:
     steps:
       - name: checkout repository
         uses: actions/checkout@v4
+      - name: install clang 14
+        uses: KyleMayes/install-llvm-action@v2
+        with:
+          version: "14"
       - name: check format
         run: ./format-files.sh check
       - name: configure

format-files.sh

@@ -15,7 +15,10 @@ CLANG_FORMAT_VERSION=$(clang-format --version 2>/dev/null)
 if [[ $CLANG_FORMAT_VERSION =~ ([0-9]+)\. ]]; then
     MAJOR_VERSION=${BASH_REMATCH[1]}
     if (( MAJOR_VERSION < 13 )); then
-        echo "clang-format version >= 13 required, got $MAJOR_VERSION"
+        echo "clang-format version >= 13 and < 18 required, got $MAJOR_VERSION"
+        exit 1
+    elif (( MAJOR_VERSION > 18 )); then # PointerAlignment: Left, v18 wants `T C::* member` v14 wants `T C::*member`
+        echo "clang-format version >= 13 and < 18 required, got $MAJOR_VERSION"
         exit 1
     else
         echo "clang-format version $MAJOR_VERSION"
@@ -34,4 +37,4 @@ fi
 find "${PROJ_ROOT}" -type f \
     \( -name "*.cpp" -o -name "*.c" -o -name "*.hpp" -o -name "*.h" \) \
     -not -path "${PROJ_ROOT}/build/*" \
-    -print0 | xargs -0 clang-format $EXTRA_FLAGS --style=file --verbose -i
+    -print0 | xargs -0 clang-format $EXTRA_FLAGS --style=file --verbose -i