GH1488 Add overload for DataFrame.max when axis is None #1490
Conversation
|
/pandas_nightly |
cmp0xff
left a comment
cmp0xff
left a comment
There was a problem hiding this comment.
Thank you for adding mean, min, median. I think we just need to relax the type testing.
| skipna: _bool | None = True, | ||
| numeric_only: _bool = False, | ||
| **kwargs: Any, | ||
| ) -> Scalar: ... |
There was a problem hiding this comment.
We can probably further restrict to _OrderableT from pandas-stubs/_libs/intervals.pyi, instead of just Scalar. But this can be done in a separate PR.
There was a problem hiding this comment.
Is it a type that can be returned? I thought it was more of a generic for Interval or something like that. I have left it for later.
There was a problem hiding this comment.
I'm not sure, either. @Dr-Irv can we return _OrderableT?
There was a problem hiding this comment.
I'm not sure, either. @Dr-Irv can we return
_OrderableT?
We can't return a TypeVar when the TypeVar is not part of the Generic in the class.
But we can create a new type that is a union of what is in _OrderableT , and that might be a better result here.
Although be careful. Because _OrderableT doesn't include str, which could be the result of max and min. Would need to check the other scalar types as well.
There was a problem hiding this comment.
Thanks, I think it may be too much hair-splitting to refine further here.
cmp0xff
left a comment
cmp0xff
left a comment
There was a problem hiding this comment.
All good. Thank you @loicdiridollou !
| skipna: _bool | None = True, | ||
| numeric_only: _bool = False, | ||
| **kwargs: Any, | ||
| ) -> Scalar: ... |
There was a problem hiding this comment.
I'm not sure, either. @Dr-Irv can we return _OrderableT?
3 participants
DataFrame.maxneeds the same overloads asDataFrame.anyhas #1488assert_type()to assert the type of any return value