Skip to content

Better error message on when the dataframe is empty for margins=True #63133

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
+42 −1
Open

Better error message on when the dataframe is empty for margins=True #63133

Changes from 4 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
cea7a2b
Descriptive error message on when the dataframe is empty and margin i…
show981111 Nov 17, 2025
6dd4c2a
Merge branch 'main' into error-on-empty-margin
show981111 Nov 17, 2025
107071b
Typo
show981111 Nov 17, 2025
6603bda
Merge branch 'error-on-empty-margin' of github.com:show981111/pandas …
show981111 Nov 17, 2025
340129a
Resolve comments
show981111 Nov 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions pandas/core/reshape/pivot.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1163,6 +1163,9 @@ def _normalize(

elif margins is True:
# keep index and column of pivoted table
if table.empty:
raise ValueError("Can't get margins since the result dataframe is empty")

table_index = table.index
table_columns = table.columns
last_ind_or_col = table.iloc[-1, :].name
Copy link
Contributor

@natmokval natmokval Nov 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for improving the error message.
I suggest leaving the error type IndexError as it is and re-raising with a different error message.

We can put this line table.iloc[-1, :].name, where we get the problem with indexing, in a try block and then re-raise:

except IndexError as err:
    raise IndexError("Can't get margins since the result dataframe is empty") from err

Copy link
Contributor

@natmokval natmokval Nov 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@show981111, could you please add a test for the new error message?

Copy link
Author

@show981111 show981111 Nov 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@natmokval Thank you for the feedback! I updated my code.

Expand Down
Loading