Provide more context when asserting OfflineStore objectId assignment issues

Author: flovilmart

Parse/Parse/Internal/LocalDataStore/OfflineStore/PFOfflineStore.m

@@ -1028,7 +1028,8 @@ - (void)updateObjectIdForObject:(PFObject *)object
         // See if there's already an entry for new objectId.
         PFObject *existing = [self.classNameAndObjectIdToObjectMap objectForKey:key];
         PFConsistencyAssert(existing == nil || existing == object,
-                            @"Attempted to change an objectId to one that's already known to the OfflineStore.");
+                            @"Attempted to change an objectId to one that's already known to the OfflineStore. className: %@ old: %@, new: %@",
+                            className, oldObjectId, newObjectId);
 
         // Okay, all clear to add the new reference.
         [self.classNameAndObjectIdToObjectMap setObject:object forKey:key];

Parse/Tests/Unit/QueryUnitTests.m

@@ -1413,4 +1413,23 @@ - (void)testHash {
     XCTAssertEqual([queryA hash], [queryB hash]);
 }
 
+- (void)testReproduceIssue1202 {
+    [[Parse _currentManager] clearEventuallyQueue];
+    [Parse _clearCurrentManager];
+    [Parse enableLocalDatastore];
+    [Parse setApplicationId:@"a" clientKey:@"b"];
+    PFObject *objectA = [PFObject objectWithClassName:@"Object" dictionary:@{@"objectId":@"yolo", @"key": @"value"}];
+    objectA.objectId = @"yolo";
+    PFObject *objectB = [PFObject objectWithClassName:@"Object" dictionary:@{@"objectId":@"yolo", @"key": @"value"}];
+    @try {
+        objectB.objectId = @"yolo";
+        XCTFail();
+    }
+    @catch (NSException *e) {
+        XCTAssertEqual(e.name, NSInternalInconsistencyException);
+        XCTAssertEqualObjects(e.reason, @"Attempted to change an objectId to one that's already known to the OfflineStore. className: Object old: (null), new: yolo");
+    }
+}
+
+
 @end