Fixes issue related to heap corruption (#1170)

* Fixes issue related to heap corruption

- a block was capturing self in dealloc through _stopMonitoring
- this removed the retain cycle at dealloc

* Better handling of EventuallyQueue termination

* Fixes issue for cocoapods

* fixup! Fixes issue for cocoapods

Author: flovilmart

Parse/Internal/PFEventuallyQueue.h

@@ -67,7 +67,7 @@ extern NSTimeInterval const PFEventuallyQueueDefaultTimeoutRetryInterval;
 - (void)start NS_REQUIRES_SUPER;
 - (void)resume NS_REQUIRES_SUPER;
 - (void)pause NS_REQUIRES_SUPER;
-- (void)stop NS_REQUIRES_SUPER;
+- (void)terminate NS_REQUIRES_SUPER;
 - (void)removeAllCommands NS_REQUIRES_SUPER;
 
 @end

Parse/Internal/PFEventuallyQueue.m

@@ -80,10 +80,6 @@ - (instancetype)initWithDataSource:(id<PFCommandRunnerProvider>)dataSource
     return self;
 }
 
-- (void)dealloc {
-    [self _stopMonitoringNetworkReachability];
-}
-
 ///--------------------------------------
 #pragma mark - Enqueueing Commands
 ///--------------------------------------
@@ -197,7 +193,8 @@ - (void)pause {
     dispatch_suspend(_processingQueueSource);
 }
 
-- (void)stop {
+- (void)terminate {
+    [self _stopMonitoringNetworkReachability];
     dispatch_source_cancel(_processingQueueSource);
 }
 
@@ -383,7 +380,6 @@ - (void)_stopMonitoringNetworkReachability {
     [[PFReachability sharedParseReachability] removeListener:self];
 
     self.monitorsReachability = NO;
-    self.connected = YES;
 #endif
 }
 
@@ -393,9 +389,11 @@ - (void)_stopMonitoringNetworkReachability {
 
 /** Manually sets the network connection status. */
 - (void)setConnected:(BOOL)connected {
+    @weakify(self);
     BFTaskCompletionSource *barrier = [BFTaskCompletionSource taskCompletionSource];
     dispatch_async(_processingQueue, ^{
         dispatch_sync(_synchronizationQueue, ^{
+            @strongify(self);
             if (self.connected != connected) {
                 _connected = connected;
                 if (connected) {

Parse/Internal/PFReachability.m

@@ -130,7 +130,9 @@ - (void)addListener:(id<PFReachabilityListener>)listener {
 }
 
 - (void)removeListener:(id<PFReachabilityListener>)listener {
+    @weakify(listener);
     dispatch_barrier_sync(_synchronizationQueue, ^{
+        @strongify(listener);
         [_listenersArray filterUsingPredicate:[NSPredicate predicateWithBlock:^BOOL(id evaluatedObject, NSDictionary *bindings) {
             id weakObject = [evaluatedObject weakObject];
             return (weakObject == nil || weakObject == listener);

Parse/Internal/ParseManager.m

@@ -181,8 +181,8 @@ - (PFEventuallyQueue *)eventuallyQueue {
                 if (commandCache.commandCount > 0) {
                     [commandCache removeAllCommands];
                 }
-                // we won't need it after stop everything...
-                [commandCache stop];
+                // we won't need it after, terminate...
+                [commandCache terminate];
             }
         }
 #endif