Skip to content

Commit 4909de3

Browse files
cbaker6cbaker6
authored
fix: saving ParseFiles locally do not throw error (#399)
* test * fix: saving ParseFiles locally do not throw error * add test * reduce flakiness in LiveQuery tests by skipping when mocking isn't working
1 parent df71568 commit 4909de3

File tree

6 files changed

+117
-26
lines changed

6 files changed

+117
-26
lines changed

‎CHANGELOG.md‎

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,9 @@
66

77
### 4.9.3
88
[Full Changelog](https://github.com/parse-community/Parse-Swift/compare/4.9.2...4.9.3)
9+
910
__Fixes__
11+
- When saving ParseFiles locally, files that have a directory in their filename save correctly instead of throwing an error on the client ([#399](https://github.com/parse-community/Parse-Swift/pull/399)), thanks to [Corey Baker](https://github.com/cbaker6).
1012
- Default to not setting kSecUseDataProtectionKeychain to true as this can cause issues with querying the Keychain in Swift Playgrounds or other apps that cannot setup the Keychain on macOS. This behavior can be changed by setting usingDataProtectionKeychain to true when initializing the SDK ([#398](https://github.com/parse-community/Parse-Swift/pull/398)), thanks to [Corey Baker](https://github.com/cbaker6).
1113

1214
### 4.9.2

‎Sources/ParseSwift/API/API+Command.swift‎

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -365,9 +365,10 @@ internal extension API.Command {
365365
let downloadDirectoryPath = defaultDirectoryPath
366366
.appendingPathComponent(ParseConstants.fileDownloadsDirectory, isDirectory: true)
367367
try fileManager.createDirectoryIfNeeded(downloadDirectoryPath.relativePath)
368-
let fileLocation = downloadDirectoryPath.appendingPathComponent(object.name)
368+
let fileNameURL = URL(fileURLWithPath: object.name)
369+
let fileLocation = downloadDirectoryPath.appendingPathComponent(fileNameURL.lastPathComponent)
369370
if tempFileLocation != fileLocation {
370-
try? FileManager.default.removeItem(at: fileLocation) //Remove file if it is already present
371+
try? FileManager.default.removeItem(at: fileLocation) // Remove file if it is already present
371372
try FileManager.default.moveItem(at: tempFileLocation, to: fileLocation)
372373
}
373374
var object = object

‎Sources/ParseSwift/ParseConstants.swift‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ import Foundation
1010

1111
enum ParseConstants {
1212
static let sdk = "swift"
13-
static let version = "4.9.2"
13+
static let version = "4.9.3"
1414
static let fileManagementDirectory = "parse/"
1515
static let fileManagementPrivateDocumentsDirectory = "Private Documents/"
1616
static let fileManagementLibraryDirectory = "Library/"

‎Sources/ParseSwift/Types/ParseFile.swift‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -149,6 +149,7 @@ public struct ParseFile: Fileable, Savable, Fetchable, Deletable, Hashable {
149149
}
150150
}
151151

152+
// MARK: Coding
152153
extension ParseFile {
153154
public init(from decoder: Decoder) throws {
154155
let values = try decoder.container(keyedBy: CodingKeys.self)

‎Tests/ParseSwiftTests/ParseFileTests.swift‎

Lines changed: 58 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1150,6 +1150,64 @@ class ParseFileTests: XCTestCase { // swiftlint:disable:this type_body_length
11501150
#endif
11511151
}
11521152

1153+
func testFetchFileWithDirInName() throws {
1154+
// swiftlint:disable:next line_length
1155+
guard let parseFileURL = URL(string: "http://localhost:1337/1/files/applicationId/d3a37aed0672a024595b766f97133615_logo.svg") else {
1156+
XCTFail("Should create URL")
1157+
return
1158+
}
1159+
var parseFile = ParseFile(name: "myFolder/d3a37aed0672a024595b766f97133615_logo.svg", cloudURL: parseFileURL)
1160+
parseFile.url = parseFileURL
1161+
1162+
let response = FileUploadResponse(name: "myFolder/d3a37aed0672a024595b766f97133615_logo.svg",
1163+
url: parseFileURL)
1164+
let encoded: Data!
1165+
do {
1166+
encoded = try ParseCoding.jsonEncoder().encode(response)
1167+
} catch {
1168+
XCTFail("Should encode/decode. Error \(error)")
1169+
return
1170+
}
1171+
MockURLProtocol.mockRequests { _ in
1172+
return MockURLResponse(data: encoded, statusCode: 200, delay: 0.0)
1173+
}
1174+
1175+
let fetchedFile = try parseFile.fetch()
1176+
XCTAssertEqual(fetchedFile.name, response.name)
1177+
XCTAssertEqual(fetchedFile.url, response.url)
1178+
guard let localURL = fetchedFile.localURL else {
1179+
XCTFail("Should have unwrapped")
1180+
return
1181+
}
1182+
XCTAssertFalse(localURL.pathComponents.contains("myFolder"))
1183+
1184+
// Cache policy flakey on older Swift versions
1185+
#if compiler(>=5.5.0)
1186+
// Remove URL mocker so we can check cache
1187+
MockURLProtocol.removeAll()
1188+
1189+
let fetchedFile2 = try parseFile.fetch(options: [.cachePolicy(.returnCacheDataDontLoad)])
1190+
XCTAssertEqual(fetchedFile2.name, fetchedFile.name)
1191+
XCTAssertEqual(fetchedFile2.url, fetchedFile.url)
1192+
XCTAssertNotNil(fetchedFile2.localURL)
1193+
1194+
// More cache tests
1195+
guard let currentMemoryUsage = URLSession.parse.configuration.urlCache?.currentMemoryUsage,
1196+
let currentDiskUsage = URLSession.parse.configuration.urlCache?.currentDiskUsage else {
1197+
XCTFail("Should have unwrapped")
1198+
return
1199+
}
1200+
XCTAssertGreaterThan(currentMemoryUsage, 0)
1201+
XCTAssertGreaterThan(currentDiskUsage, 0)
1202+
ParseSwift.clearCache()
1203+
guard let updatedMemoryUsage = URLSession.parse.configuration.urlCache?.currentMemoryUsage else {
1204+
XCTFail("Should have unwrapped")
1205+
return
1206+
}
1207+
XCTAssertLessThan(updatedMemoryUsage, currentMemoryUsage)
1208+
#endif
1209+
}
1210+
11531211
func testFetchFileProgress() throws {
11541212
// swiftlint:disable:next line_length
11551213
guard let parseFileURL = URL(string: "http://localhost:1337/1/files/applicationId/d3a37aed0672a024595b766f97133615_logo.svg") else {

‎Tests/ParseSwiftTests/ParseLiveQueryTests.swift‎

Lines changed: 52 additions & 23 deletions
Original file line numberDiff line numberDiff line change
@@ -352,7 +352,11 @@ class ParseLiveQueryTests: XCTestCase {
352352
client.attempts = 5
353353
client.clientId = "yolo"
354354
client.isDisconnectedByUser = false
355-
XCTAssertEqual(URLSession.liveQuery.receivingTasks[task], true)
355+
// Only continue test if this is not nil, otherwise skip
356+
guard let receivingTask = URLSession.liveQuery.receivingTasks[task] else {
357+
throw XCTSkip("Skip this test when the receiving task is nil")
358+
}
359+
XCTAssertEqual(receivingTask, true)
356360
XCTAssertEqual(client.isSocketEstablished, true)
357361
XCTAssertEqual(client.isConnecting, false)
358362
XCTAssertEqual(client.clientId, "yolo")
@@ -382,7 +386,11 @@ class ParseLiveQueryTests: XCTestCase {
382386
client.isConnecting = true
383387
client.isConnected = true
384388
client.clientId = "yolo"
385-
XCTAssertEqual(URLSession.liveQuery.receivingTasks[task], true)
389+
// Only continue test if this is not nil, otherwise skip
390+
guard let receivingTask = URLSession.liveQuery.receivingTasks[task] else {
391+
throw XCTSkip("Skip this test when the receiving task is nil")
392+
}
393+
XCTAssertEqual(receivingTask, true)
386394
XCTAssertEqual(client.isConnected, true)
387395
XCTAssertEqual(client.isConnecting, false)
388396
XCTAssertEqual(client.clientId, "yolo")
@@ -461,7 +469,11 @@ class ParseLiveQueryTests: XCTestCase {
461469
client.receiveDelegate = delegate
462470
client.task = URLSession.liveQuery.createTask(client.url,
463471
taskDelegate: client)
464-
XCTAssertEqual(URLSession.liveQuery.receivingTasks[client.task], true)
472+
// Only continue test if this is not nil, otherwise skip
473+
guard let receivingTask = URLSession.liveQuery.receivingTasks[client.task] else {
474+
throw XCTSkip("Skip this test when the receiving task is nil")
475+
}
476+
XCTAssertEqual(receivingTask, true)
465477
client.status(.closed, closeCode: .goingAway, reason: nil)
466478
let expectation1 = XCTestExpectation(description: "Response delegate")
467479
DispatchQueue.main.asyncAfter(deadline: .now() + 2) {
@@ -476,12 +488,15 @@ class ParseLiveQueryTests: XCTestCase {
476488

477489
func testCloseExternal() throws {
478490
let client = try ParseLiveQuery()
479-
guard let originalTask = client.task else {
480-
XCTFail("Should not be nil")
481-
return
491+
guard let originalTask = client.task,
492+
client.task.state == .running else {
493+
throw XCTSkip("Skip this test when state is not running")
482494
}
483-
XCTAssertTrue(client.task.state == .running)
484-
XCTAssertEqual(URLSession.liveQuery.receivingTasks[client.task], true)
495+
// Only continue test if this is not nil, otherwise skip
496+
guard let receivingTask = URLSession.liveQuery.receivingTasks[client.task] else {
497+
throw XCTSkip("Skip this test when the receiving task is nil")
498+
}
499+
XCTAssertEqual(receivingTask, true)
485500
client.isSocketEstablished = true
486501
client.isConnected = true
487502
client.close()
@@ -501,12 +516,15 @@ class ParseLiveQueryTests: XCTestCase {
501516

502517
func testCloseInternalUseQueue() throws {
503518
let client = try ParseLiveQuery()
504-
guard let originalTask = client.task else {
505-
XCTFail("Should not be nil")
506-
return
519+
guard let originalTask = client.task,
520+
client.task.state == .running else {
521+
throw XCTSkip("Skip this test when state is not running")
507522
}
508-
XCTAssertTrue(client.task.state == .running)
509-
XCTAssertEqual(URLSession.liveQuery.receivingTasks[client.task], true)
523+
// Only continue test if this is not nil, otherwise skip
524+
guard let receivingTask = URLSession.liveQuery.receivingTasks[client.task] else {
525+
throw XCTSkip("Skip this test when the receiving task is nil")
526+
}
527+
XCTAssertEqual(receivingTask, true)
510528
client.isSocketEstablished = true
511529
client.isConnected = true
512530
client.close(useDedicatedQueue: true)
@@ -526,12 +544,15 @@ class ParseLiveQueryTests: XCTestCase {
526544

527545
func testCloseInternalDoNotUseQueue() throws {
528546
let client = try ParseLiveQuery()
529-
guard let originalTask = client.task else {
530-
XCTFail("Should not be nil")
531-
return
547+
guard let originalTask = client.task,
548+
client.task.state == .running else {
549+
throw XCTSkip("Skip this test when state is not running")
532550
}
533-
XCTAssertTrue(client.task.state == .running)
534-
XCTAssertEqual(URLSession.liveQuery.receivingTasks[client.task], true)
551+
// Only continue test if this is not nil, otherwise skip
552+
guard let receivingTask = URLSession.liveQuery.receivingTasks[client.task] else {
553+
throw XCTSkip("Skip this test when the receiving task is nil")
554+
}
555+
XCTAssertEqual(receivingTask, true)
535556
client.isSocketEstablished = true
536557
client.isConnected = true
537558
client.close(useDedicatedQueue: false)
@@ -546,12 +567,15 @@ class ParseLiveQueryTests: XCTestCase {
546567

547568
func testCloseAll() throws {
548569
let client = try ParseLiveQuery()
549-
guard let originalTask = client.task else {
550-
XCTFail("Should not be nil")
551-
return
570+
guard let originalTask = client.task,
571+
client.task.state == .running else {
572+
throw XCTSkip("Skip this test when state is not running")
552573
}
553-
XCTAssertTrue(client.task.state == .running)
554-
XCTAssertEqual(URLSession.liveQuery.receivingTasks[client.task], true)
574+
// Only continue test if this is not nil, otherwise skip
575+
guard let receivingTask = URLSession.liveQuery.receivingTasks[client.task] else {
576+
throw XCTSkip("Skip this test when the receiving task is nil")
577+
}
578+
XCTAssertEqual(receivingTask, true)
555579
client.isSocketEstablished = true
556580
client.isConnected = true
557581
client.closeAll()
@@ -651,6 +675,11 @@ class ParseLiveQueryTests: XCTestCase {
651675
let response = ConnectionResponse(op: .connected, clientId: "yolo", installationId: "naw")
652676
let encoded = try ParseCoding.jsonEncoder().encode(response)
653677
client.received(encoded)
678+
// Only continue test if this is not nil, otherwise skip
679+
guard let receivingTask = URLSession.liveQuery.receivingTasks[client.task],
680+
receivingTask == true else {
681+
throw XCTSkip("Skip this test when the receiving task is nil or not true")
682+
}
654683
}
655684

656685
func testSubscribeConnected() throws {

0 commit comments

Comments
 (0)