rename

Author: mtrezza

spec/MongoStorageAdapter.spec.js

@@ -825,12 +825,12 @@ describe_only_db('mongo')('MongoStorageAdapter', () => {
     });
   });
 
-  describe('clientLogEvents', () => {
+  describe('logClientEvents', () => {
     it('should log MongoDB client events when configured', async () => {
       const logger = require('../lib/logger').logger;
       const logSpy = spyOn(logger, 'warn');
 
-      const clientLogEvents = [
+      const logClientEvents = [
         {
           name: 'serverDescriptionChanged',
           keys: ['address'],
@@ -840,7 +840,7 @@ describe_only_db('mongo')('MongoStorageAdapter', () => {
 
       const adapter = new MongoStorageAdapter({
         uri: databaseURI,
-        mongoOptions: { clientLogEvents },
+        mongoOptions: { logClientEvents },
       });
 
       // Connect to trigger event listeners setup
@@ -867,7 +867,7 @@ describe_only_db('mongo')('MongoStorageAdapter', () => {
       const logger = require('../lib/logger').logger;
       const logSpy = spyOn(logger, 'info');
 
-      const clientLogEvents = [
+      const logClientEvents = [
         {
           name: 'connectionPoolReady',
           logLevel: 'info',
@@ -876,7 +876,7 @@ describe_only_db('mongo')('MongoStorageAdapter', () => {
 
       const adapter = new MongoStorageAdapter({
         uri: databaseURI,
-        mongoOptions: { clientLogEvents },
+        mongoOptions: { logClientEvents },
       });
 
       await adapter.connect();
@@ -899,7 +899,7 @@ describe_only_db('mongo')('MongoStorageAdapter', () => {
       const logger = require('../lib/logger').logger;
       const logSpy = spyOn(logger, 'warn');
 
-      const clientLogEvents = [
+      const logClientEvents = [
         {
           name: 'topologyDescriptionChanged',
           keys: ['previousDescription.type', 'newDescription.type', 'newDescription.servers.size'],
@@ -909,7 +909,7 @@ describe_only_db('mongo')('MongoStorageAdapter', () => {
 
       const adapter = new MongoStorageAdapter({
         uri: databaseURI,
-        mongoOptions: { clientLogEvents },
+        mongoOptions: { logClientEvents },
       });
 
       await adapter.connect();
@@ -936,7 +936,7 @@ describe_only_db('mongo')('MongoStorageAdapter', () => {
       const logger = require('../lib/logger').logger;
       const infoSpy = spyOn(logger, 'info');
 
-      const clientLogEvents = [
+      const logClientEvents = [
         {
           name: 'connectionPoolReady',
           keys: ['address'],
@@ -946,7 +946,7 @@ describe_only_db('mongo')('MongoStorageAdapter', () => {
 
       const adapter = new MongoStorageAdapter({
         uri: databaseURI,
-        mongoOptions: { clientLogEvents },
+        mongoOptions: { logClientEvents },
       });
 
       await adapter.connect();
@@ -969,7 +969,7 @@ describe_only_db('mongo')('MongoStorageAdapter', () => {
       const logger = require('../lib/logger').logger;
       const warnSpy = spyOn(logger, 'warn');
 
-      const clientLogEvents = [
+      const logClientEvents = [
         {
           name: 'customEvent',
           logLevel: 'warn',
@@ -978,7 +978,7 @@ describe_only_db('mongo')('MongoStorageAdapter', () => {
 
       const adapter = new MongoStorageAdapter({
         uri: databaseURI,
-        mongoOptions: { clientLogEvents },
+        mongoOptions: { logClientEvents },
       });
 
       await adapter.connect();
@@ -1002,7 +1002,7 @@ describe_only_db('mongo')('MongoStorageAdapter', () => {
       const logger = require('../lib/logger').logger;
       const infoSpy = spyOn(logger, 'info');
 
-      const clientLogEvents = [
+      const logClientEvents = [
         {
           name: 'testEvent',
           keys: ['nonexistent.nested.key', 'another.missing'],
@@ -1012,7 +1012,7 @@ describe_only_db('mongo')('MongoStorageAdapter', () => {
 
       const adapter = new MongoStorageAdapter({
         uri: databaseURI,
-        mongoOptions: { clientLogEvents },
+        mongoOptions: { logClientEvents },
       });
 
       await adapter.connect();
@@ -1035,7 +1035,7 @@ describe_only_db('mongo')('MongoStorageAdapter', () => {
       const logger = require('../lib/logger').logger;
       const warnSpy = spyOn(logger, 'warn');
 
-      const clientLogEvents = [
+      const logClientEvents = [
         {
           name: 'circularEvent',
           logLevel: 'info',
@@ -1044,7 +1044,7 @@ describe_only_db('mongo')('MongoStorageAdapter', () => {
 
       const adapter = new MongoStorageAdapter({
         uri: databaseURI,
-        mongoOptions: { clientLogEvents },
+        mongoOptions: { logClientEvents },
       });
 
       await adapter.connect();

src/Adapters/Storage/Mongo/MongoStorageAdapter.js

@@ -1,16 +1,16 @@
 // @flow
+import { format as formatUrl, parse as parseUrl } from '../../../vendor/mongodbUrl';
+import type { QueryOptions, QueryType, SchemaType, StorageClass } from '../StorageAdapter';
+import { StorageAdapter } from '../StorageAdapter';
 import MongoCollection from './MongoCollection';
 import MongoSchemaCollection from './MongoSchemaCollection';
-import { StorageAdapter } from '../StorageAdapter';
-import type { SchemaType, QueryType, StorageClass, QueryOptions } from '../StorageAdapter';
-import { parse as parseUrl, format as formatUrl } from '../../../vendor/mongodbUrl';
 import {
-  parseObjectToMongoObjectForCreate,
   mongoObjectToParseObject,
+  parseObjectToMongoObjectForCreate,
   transformKey,
-  transformWhere,
-  transformUpdate,
   transformPointerString,
+  transformUpdate,
+  transformWhere,
 } from './MongoTransform';
 // @flow-disable-next
 import Parse from 'parse/node';
@@ -132,7 +132,7 @@ export class MongoStorageAdapter implements StorageAdapter {
   _mongoOptions: Object;
   _onchange: any;
   _stream: any;
-  _clientLogEvents: ?Array<any>;
+  _logClientEvents: ?Array<any>;
   // Public
   connectionPromise: ?Promise<any>;
   database: any;
@@ -155,7 +155,7 @@ export class MongoStorageAdapter implements StorageAdapter {
     this.enableSchemaHooks = !!mongoOptions.enableSchemaHooks;
     this.schemaCacheTtl = mongoOptions.schemaCacheTtl;
     this.disableIndexFieldValidation = !!mongoOptions.disableIndexFieldValidation;
-    this._clientLogEvents = mongoOptions.clientLogEvents;
+    this._logClientEvents = mongoOptions.logClientEvents;
     // Remove Parse Server-specific options that should not be passed to MongoDB client
     // Note: We only delete from this._mongoOptions, not from the original mongoOptions object,
     // because other components (like DatabaseController) need access to these options
@@ -164,7 +164,7 @@ export class MongoStorageAdapter implements StorageAdapter {
       'schemaCacheTtl',
       'maxTimeMS',
       'disableIndexFieldValidation',
-      'clientLogEvents',
+      'logClientEvents',
       'createIndexUserUsername',
       'createIndexUserUsernameCaseInsensitive',
       'createIndexUserEmail',
@@ -208,8 +208,8 @@ export class MongoStorageAdapter implements StorageAdapter {
         });
 
         // Set up client event logging if configured
-        if (this._clientLogEvents && Array.isArray(this._clientLogEvents)) {
-          this._clientLogEvents.forEach(eventConfig => {
+        if (this._logClientEvents && Array.isArray(this._logClientEvents)) {
+          this._logClientEvents.forEach(eventConfig => {
             client.on(eventConfig.name, event => {
               try {
                 let logData = {};

src/Options/Definitions.js

@@ -1117,12 +1117,6 @@ module.exports.DatabaseOptions = {
       'The MongoDB driver option to specify the amount of time in milliseconds to wait for a connection attempt to finish before trying the next address when using the autoSelectFamily option. If set to a positive integer less than 10, the value 10 is used instead.',
     action: parsers.numberParser('autoSelectFamilyAttemptTimeout'),
   },
-  clientLogEvents: {
-    env: 'PARSE_SERVER_DATABASE_CLIENT_LOG_EVENTS',
-    help:
-      "An array of MongoDB client event configurations to enable logging of specific events. Each configuration object should contain:<br><ul><li>`name` (the event name, e.g., 'topologyDescriptionChanged', 'serverDescriptionChanged', 'connectionPoolCleared', 'connectionPoolReady')</li><li>`keys` (optional array of dot-notation paths to extract specific data from the event object; if not provided or empty, the entire event object will be logged)</li><li>`logLevel` (the log level to use for this event: 'error', 'warn', 'info', 'debug', etc.).</li></ul>",
-    action: parsers.arrayParser,
-  },
   compressors: {
     env: 'PARSE_SERVER_DATABASE_COMPRESSORS',
     help:
@@ -1225,6 +1219,12 @@ module.exports.DatabaseOptions = {
       'The MongoDB driver option to specify the size (in milliseconds) of the latency window for selecting among multiple suitable MongoDB instances.',
     action: parsers.numberParser('localThresholdMS'),
   },
+  logClientEvents: {
+    env: 'PARSE_SERVER_DATABASE_LOG_CLIENT_EVENTS',
+    help:
+      "An array of MongoDB client event configurations to enable logging of specific events. Each configuration object should contain:<br><ul><li>`name` (the event name, e.g., 'topologyDescriptionChanged', 'serverDescriptionChanged', 'connectionPoolCleared', 'connectionPoolReady')</li><li>`keys` (optional array of dot-notation paths to extract specific data from the event object; if not provided or empty, the entire event object will be logged)</li><li>`logLevel` (the log level to use for this event: 'error', 'warn', 'info', 'debug', etc.).</li></ul>",
+    action: parsers.arrayParser,
+  },
   maxConnecting: {
     env: 'PARSE_SERVER_DATABASE_MAX_CONNECTING',
     help:

src/Options/docs.js

@@ -608,7 +608,7 @@ export interface FileUploadOptions {
   enableForPublic: ?boolean;
 }
 
-export type ClientLogEvent = {
+export type LogClientEvent = {
   /* The MongoDB driver event name to listen for. */
   name: string,
   /* Optional array of dot-notation paths to extract specific data from the event object. If not provided or empty, the entire event object will be logged. */
@@ -735,7 +735,7 @@ export interface DatabaseOptions {
   /* Set to `true` to disable validation of index fields. When disabled, indexes can be created even if the fields do not exist in the schema. This can be useful when creating indexes on fields that will be added later. */
   disableIndexFieldValidation: ?boolean;
   /* An array of MongoDB client event configurations to enable logging of specific events. Each configuration object should contain:<br><ul><li>`name` (the event name, e.g., 'topologyDescriptionChanged', 'serverDescriptionChanged', 'connectionPoolCleared', 'connectionPoolReady')</li><li>`keys` (optional array of dot-notation paths to extract specific data from the event object; if not provided or empty, the entire event object will be logged)</li><li>`logLevel` (the log level to use for this event: 'error', 'warn', 'info', 'debug', etc.).</li></ul> */
-  clientLogEvents: ?(ClientLogEvent[]);
+  logClientEvents: ?(LogClientEvent[]);
 }
 
 export interface AuthAdapter {