Change List<byte[]> storedDevicePublicKeys to IReadOnlyList<byte[]> (#477)

Author: joegoldman2

Src/Fido2/AuthenticatorAssertionResponse.cs

@@ -57,7 +57,7 @@ public async Task<VerifyAssertionResult> VerifyAsync(
         AssertionOptions options,
         Fido2Configuration config,
         byte[] storedPublicKey,
-        List<byte[]> storedDevicePublicKeys,
+        IReadOnlyList<byte[]> storedDevicePublicKeys,
         uint storedSignatureCounter,
         IsUserHandleOwnerOfCredentialIdAsync isUserHandleOwnerOfCredId,
         IMetadataService? metadataService,
@@ -235,7 +235,7 @@ public async Task<VerifyAssertionResult> VerifyAsync(
     /// <param name="hash"></param>
     /// </summary>
     private static async ValueTask<byte[]?> DevicePublicKeyAuthenticationAsync(
-        List<byte[]> storedDevicePublicKeys,
+        IReadOnlyList<byte[]> storedDevicePublicKeys,
         AuthenticationExtensionsClientOutputs clientExtensionResults,
         AuthenticatorData authData,
         byte[] hash)
@@ -320,7 +320,7 @@ public async Task<VerifyAssertionResult> VerifyAsync(
                 List<DevicePublicKeyAuthenticatorOutput> matchedDpkKeys = new();
 
                 // For each dpkRecord in credentialRecord.devicePubKeys
-                storedDevicePublicKeys.ForEach(storedDevicePublicKey =>
+                foreach (var storedDevicePublicKey in storedDevicePublicKeys)
                 {
                     var dpkRecord = DevicePublicKeyAuthenticatorOutput.Parse(storedDevicePublicKey);
 
@@ -330,7 +330,7 @@ public async Task<VerifyAssertionResult> VerifyAsync(
                         // Append dpkRecord to matchedDpkKeys.
                         matchedDpkKeys.Add(dpkRecord);
                     }
-                });
+                }
 
                 // If matchedDpkKeys is empty
                 if (matchedDpkKeys.Count == 0)

Src/Fido2/Fido2.cs

@@ -108,7 +108,7 @@ public async Task<VerifyAssertionResult> MakeAssertionAsync(
         AuthenticatorAssertionRawResponse assertionResponse,
         AssertionOptions originalOptions,
         byte[] storedPublicKey,
-        List<byte[]> storedDevicePublicKeys,
+        IReadOnlyList<byte[]> storedDevicePublicKeys,
         uint storedSignatureCounter,
         IsUserHandleOwnerOfCredentialIdAsync isUserHandleOwnerOfCredentialIdCallback,
         CancellationToken cancellationToken = default)

Src/Fido2/IFido2.cs

@@ -17,7 +17,7 @@ Task<VerifyAssertionResult> MakeAssertionAsync(
         AuthenticatorAssertionRawResponse assertionResponse,
         AssertionOptions originalOptions,
         byte[] storedPublicKey,
-        List<byte[]> storedDevicePublicKeys,
+        IReadOnlyList<byte[]> storedDevicePublicKeys,
         uint storedSignatureCounter,
         IsUserHandleOwnerOfCredentialIdAsync isUserHandleOwnerOfCredentialIdCallback,
         CancellationToken cancellationToken = default);