Merge pull request #5 from patchlevel/fix-enums

Upgrade phpcs rules to fix enums

Author: DanielBadura

.github/workflows/release-on-milestone-closed-triggering-release-event.yml renamed to .github/workflows/release-on-milestone-closed-triggering-release-event.yaml

@@ -0,0 +1,44 @@
+# https://help.github.com/en/categories/automating-your-workflow-with-github-actions
+
+name: "Check Coding Standard"
+
+on:
+  pull_request:
+  push:
+    branches:
+      - "[0-9]+.[0-9]+.x"
+      - "renovate/*"
+
+jobs:
+  static-analysis-coding-standard:
+    name: "Static Analysis by patchlevel/coding-standard"
+
+    runs-on: ${{ matrix.operating-system }}
+
+    strategy:
+      matrix:
+        dependencies:
+          - "locked"
+        php-version:
+          - "8.1"
+        operating-system:
+          - "ubuntu-latest"
+
+    steps:
+      - name: "Checkout"
+        uses: "actions/checkout@v2"
+
+      - name: "Install PHP"
+        uses: "shivammathur/setup-php@v2"
+        with:
+          coverage: "pcov"
+          php-version: "${{ matrix.php-version }}"
+          ini-values: memory_limit=-1
+          extensions: pdo_sqlite
+
+      - uses: "ramsey/composer-install@v2"
+        with:
+          dependency-versions: ${{ matrix.dependencies }}
+
+      - name: "Coding Standard"
+        run: "vendor/bin/phpcs tests/fixed"

.github/workflows/test.yaml

@@ -28,11 +28,14 @@
     ],
     "require": {
         "php": "^7.4 || ^8.0",
-        "dealerdirect/phpcodesniffer-composer-installer": "^0.7.1",
-        "slevomat/coding-standard": "^7.0.10",
-        "squizlabs/php_codesniffer": "^3.6.0"
+        "dealerdirect/phpcodesniffer-composer-installer": "^0.7.2",
+        "slevomat/coding-standard": "^8.1.0",
+        "squizlabs/php_codesniffer": "^3.7.1"
     },
     "config": {
-        "sort-packages": true
+        "sort-packages": true,
+        "allow-plugins": {
+            "dealerdirect/phpcodesniffer-composer-installer": true
+        }
     }
 }

composer.json

@@ -14,5 +14,5 @@
     <arg value="p"/>
     <file>src</file>
 
-    <rule ref="Patchlevel"/>
+    <rule ref="PatchlevelCodingStandard"/>
 </ruleset>

phpcs.xml.dist

@@ -396,7 +396,7 @@
             </property>
         </properties>
     </rule>
-    <rule ref="SlevomatCodingStandard.TypeHints.PropertyTypeHintSpacing"/>
+    <rule ref="SlevomatCodingStandard.Classes.PropertyDeclaration"/>
     <rule ref="SlevomatCodingStandard.TypeHints.ReturnTypeHint">
         <properties>
             <property name="traversableTypeHints" type="array">

src/PatchlevelCodingStandard/ruleset.xml

@@ -0,0 +1,13 @@
+<?php
+
+declare(strict_types=1);
+
+namespace Tests\Fixed;
+
+enum Suit: string
+{
+    case Hearts = 'H';
+    case Diamonds = 'D';
+    case Clubs = 'C';
+    case Spades = 'S';
+}