Merge pull request #779 from patchlevel/improve-error-detected-exception

add first previous exception in error detected exception for better stack trace

Author: DavidBadura

src/Subscription/Engine/ErrorDetected.php

@@ -6,8 +6,7 @@
 
 use RuntimeException;
 
-use function array_map;
-use function implode;
+use function count;
 use function sprintf;
 
 final class ErrorDetected extends RuntimeException
@@ -16,15 +15,14 @@ final class ErrorDetected extends RuntimeException
     public function __construct(
         public readonly array $errors,
     ) {
-        $sentences = array_map(
-            static fn (Error $error) => sprintf(
-                'Subscription %s: %s',
-                $error->subscriptionId,
-                $error->message,
+        parent::__construct(
+            sprintf(
+                '%s error(s) in subscription engine detected. First error is in "%s" subscription: %s',
+                count($errors),
+                $errors[0]->subscriptionId,
+                $errors[0]->message,
             ),
-            $errors,
+            previous: $errors[0]->throwable,
         );
-
-        parent::__construct("Error in subscription engine detected.\n" . implode("\n", $sentences));
     }
 }

tests/Unit/Subscription/Engine/ErrorDetectedTest.php

@@ -24,8 +24,12 @@ public function testError(): void
 
         self::assertSame($errors, $errorDetected->errors);
         self::assertSame(
-            "Error in subscription engine detected.\nSubscription id1: error1\nSubscription id2: error2",
+            '2 error(s) in subscription engine detected. First error is in "id1" subscription: error1',
             $errorDetected->getMessage(),
         );
+        self::assertSame(
+            $errors[0]->throwable,
+            $errorDetected->getPrevious(),
+        );
     }
 }