Skip to content

Commit 9660350

Browse files
fix: further consolidate built in modules
1 parent 567cb30 commit 9660350

File tree

6 files changed

+31
-11
lines changed

6 files changed

+31
-11
lines changed

src/commands/serve.ts

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -23,9 +23,9 @@ import { appEnvironmentVariables } from '../utilities/environment-variables'
2323
import { renderSassDir } from '../utilities/sass'
2424
import { exec, execSync } from 'child_process'
2525
import { NgSwPlugin } from '../fusebox/ng.sw.plugin'
26+
import { copy } from 'fs-extra'
2627
import clearTerminal from '../utilities/clear'
2728
import readConfig_ from '../utilities/read-config'
28-
import { copy } from 'fs-extra'
2929

3030
command(
3131
'serve [port][prod][aot][sw]',
@@ -70,6 +70,11 @@ function serve(isProdBuild = false, isServiceWorkerEnabled = false) {
7070
const browserOutput = resolve(config.fusebox.browser.outputDir)
7171
const modulesFolder = resolve(process.cwd(), 'node_modules')
7272
const watchDir = resolve(`${homeDir}/src/**`)
73+
const appName =
74+
(config.favicon &&
75+
config.favicon.config &&
76+
config.favicon.config.appName) ||
77+
'FUSING ANGULAR'
7378
const browserModule = isAotBuild
7479
? config.fusebox.browser.aotBrowserModule
7580
: config.fusebox.browser.browserModule
@@ -96,7 +101,7 @@ function serve(isProdBuild = false, isServiceWorkerEnabled = false) {
96101
template: resolve('src/app/index.pug'),
97102
engine: 'pug',
98103
locals: {
99-
pageTitle: 'FUSING ANGULAR',
104+
pageTitle: appName,
100105
isLocalDev,
101106
faviconMeta: (config.generatedMetaTags || []).join('\n')
102107
}

src/modules/fusing-angular/browser.ts

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4,10 +4,16 @@ import { CookiesBrowserModule } from '../cookies/browser'
44
import { EnvironmentBrowserModule } from '../environment'
55
import { ResponseBrowserModule } from '../response/browser'
66
import { ServiceWorkerModule } from '@angular/service-worker'
7+
import {
8+
BrowserTransferStateModule,
9+
BrowserModule
10+
} from '@angular/platform-browser'
711

812
// tslint:disable-next-line:no-class
913
@NgModule({
1014
imports: [
15+
BrowserModule.withServerTransition({ appId: 'app-root' }),
16+
BrowserTransferStateModule,
1117
ServiceWorkerModule.register('/js/ngsw-worker.js', {
1218
enabled: false
1319
}),
@@ -17,6 +23,8 @@ import { ServiceWorkerModule } from '@angular/service-worker'
1723
ResponseBrowserModule
1824
],
1925
exports: [
26+
BrowserModule,
27+
BrowserTransferStateModule,
2028
ServiceWorkerModule,
2129
WindowBrowserModule,
2230
CookiesBrowserModule,

src/modules/fusing-angular/server.ts

Lines changed: 10 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3,20 +3,28 @@ import { WindowServerModule } from '../util/window/window-server.module'
33
import { EnvironmentServerModule } from '../environment'
44
import { CookiesServerModule } from '../cookies/server'
55
import { ResponseServerModule } from '../response/server'
6+
import {
7+
ServerModule,
8+
ServerTransferStateModule
9+
} from '@angular/platform-server'
610

711
// tslint:disable-next-line:no-class
812
@NgModule({
913
imports: [
14+
ServerTransferStateModule,
1015
WindowServerModule.forRoot({}),
1116
EnvironmentServerModule,
1217
CookiesServerModule,
13-
ResponseServerModule
18+
ResponseServerModule,
19+
ServerModule
1420
],
1521
exports: [
22+
ServerTransferStateModule,
1623
WindowServerModule,
1724
EnvironmentServerModule,
1825
CookiesServerModule,
19-
ResponseServerModule
26+
ResponseServerModule,
27+
ServerModule
2028
]
2129
})
2230
export class FusingAngularServerModule {}

src/modules/util/config-server.ts

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,3 @@
1+
export function fngRawEnvironmentConfig<T>() {
2+
return JSON.parse(process.env.FUSING_ANGULAR || '{}') as T
3+
}

src/templates/core/browser/app.browser.module.ts.txt

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,16 +1,14 @@
11
import { AppModule } from '../app/app.module'
22
import { NgModule } from '@angular/core'
3-
import { BrowserTransferStateModule, BrowserModule } from '@angular/platform-browser'
43
import { AppComponent } from '../app/app.component'
54
import { FusingAngularBrowserModule } from 'fusing-angular-cli/.build/modules/src/modules/fusing-angular/browser'
65

76
@NgModule({
87
imports: [
9-
BrowserModule.withServerTransition({ appId: 'app-root' }),
10-
BrowserTransferStateModule,
118
FusingAngularBrowserModule,
129
AppModule
1310
],
11+
exports: [AppModule],
1412
bootstrap: [AppComponent]
1513
})
1614
export class AppBrowserModule { }
Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,17 +1,15 @@
11
import { NgModule } from '@angular/core'
2-
import { ServerModule, ServerTransferStateModule } from '@angular/platform-server'
32
import { AppModule } from '../app/app.module'
43
import { AppComponent } from '../app/app.component'
54
import { FusingAngularServerModule } from 'fusing-angular-cli/.build/modules/src/modules/fusing-angular/server'
65

76
@NgModule({
87
imports: [
9-
ServerTransferStateModule,
108
FusingAngularServerModule,
11-
ServerModule,
129
AppModule
1310
],
14-
bootstrap: [AppComponent],
11+
exports: [AppModule],
12+
bootstrap: [AppComponent]
1513
})
1614
export class AppServerModule {
1715
}

0 commit comments

Comments
 (0)