Skip to content

Conversation

@daveshanley
Copy link
Member

No description provided.

@daveshanley daveshanley requested a review from Copilot December 2, 2025 23:32
Copilot finished reviewing on behalf of daveshanley December 2, 2025 23:36
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR is version release v0.29.0, introducing several enhancements and bug fixes to the OpenAPI comparison and indexing functionality:

  • Enhanced security requirement change tracking to show scheme names instead of generic "security" labels
  • Added comprehensive encoding support for complex YAML values (extensions, examples) with new CreateChangeWithEncoding functions
  • Improved parameter reference preservation with a new PreserveParameterReference helper function
  • Fixed URL path handling in resolver by using path.Dir instead of filepath.Dir for URL paths
  • Added context line tracking improvements for schema type changes

Reviewed changes

Copilot reviewed 21 out of 21 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
what-changed/what_changed_test.go Updated test expectations to reflect 3 additional changes detected (75→78)
what-changed/reports/summary_test.go Updated test expectations for tags label changes (3→6)
what-changed/model/security_requirement_test.go Added comprehensive tests for scope and scheme additions/removals with proper property naming
what-changed/model/security_requirement.go Refactored to use scheme names as properties and removed unused import
what-changed/model/schema_test.go Added test for type change context lines and fixed nil parameter in existing test
what-changed/model/schema.go Added schema proxy parameters for context line tracking and replaced example handling with encoding functions
what-changed/model/path_item.go Added reference tracking maps for parameter comparisons
what-changed/model/parameter_test.go Added comprehensive test for parameter reference preservation
what-changed/model/parameter.go Refactored example checking to use encoding functions
what-changed/model/operation.go Added reference tracking and changed parameter values from name strings to full objects
what-changed/model/media_type.go Replaced inline example encoding logic with reusable encoding functions
what-changed/model/header.go Replaced example property check with encoding functions
what-changed/model/extensions.go Updated to use encoding-aware comparison functions
what-changed/model/example.go Replaced inline encoding logic with CreateChangeWithEncoding calls
what-changed/model/comparison_functions_test.go Added comprehensive tests for new encoding and reference preservation functions
what-changed/model/comparison_functions.go Added encoding-aware comparison functions and parameter reference helper
what-changed/model/change_types_test.go Added tests for new encoded fields in Change struct
what-changed/model/change_types.go Added OriginalEncoded and NewEncoded fields for complex values
index/search_index.go Added fallback reference resolution through all rolodex indexes
index/resolver.go Fixed URL path handling to use path.Dir instead of filepath.Dir
datamodel/spec_info.go Removed dead code assignment to parsed variable

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@codecov
Copy link

codecov bot commented Dec 2, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.69%. Comparing base (9cc4186) to head (8bc7c8c).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #483   +/-   ##
=======================================
  Coverage   99.69%   99.69%           
=======================================
  Files         171      171           
  Lines       20355    20413   +58     
=======================================
+ Hits        20293    20351   +58     
  Misses         57       57           
  Partials        5        5           
Flag Coverage Δ
unittests 99.69% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Also added a last ditch effort to locate specs that have been pulled in remotely that use relative paths.

This last ditch effort may end up returning an invalid file, but it’s highly unlikely and at this point, something is better than nothing.
After extensive testing with the doctor and reviewing all kinds of rendering, some gaps and issues were discovered, and addressed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants