@@ -214,7 +214,7 @@ void MainWindow::checkPcb2gcodeVersion()
214
214
QStringList versionSplit = pcb2gcodeVersion.split (' .' );
215
215
QVector<int > versionNumbers;
216
216
217
- for (const QString& str : versionSplit)
217
+ foreach (const QString& str, versionSplit)
218
218
{
219
219
versionNumbers.append (str.toInt ());
220
220
}
@@ -323,11 +323,11 @@ void MainWindow::generateImages()
323
323
324
324
arguments += getCmdLineArguments ();
325
325
326
- for (QString& option : arguments)
326
+ for (QStringList::iterator i = arguments. begin (); i != arguments. end (); i++ )
327
327
{
328
- if (option. startsWith (" --output-dir" ))
328
+ if (i-> startsWith (" --output-dir" ))
329
329
{
330
- option = " --output-dir=" + imagesFolder;
330
+ *i = " --output-dir=" + imagesFolder;
331
331
found_output_dir = true ;
332
332
break ;
333
333
}
@@ -347,6 +347,19 @@ void MainWindow::generateImages()
347
347
pcb2gcodeImageProcess.start (PCB2GCODE_EXECUTABLE, arguments, QProcess::ReadOnly);
348
348
}
349
349
350
+ void MainWindow::addImageFile (const QDir& dir, const QString& item, const QString& filename)
351
+ {
352
+ foreach (const QFileInfo& image, dir.entryInfoList ())
353
+ {
354
+ if (image.baseName ().contains (filename))
355
+ {
356
+ imagesFilename.append (image.absoluteFilePath ());
357
+ ui->imageComboBox ->addItem (item);
358
+ break ;
359
+ }
360
+ }
361
+ }
362
+
350
363
void MainWindow::imagesGenerated (int exitCode, QProcess::ExitStatus exitStatus)
351
364
{
352
365
loadingIcon.stop ();
@@ -356,19 +369,6 @@ void MainWindow::imagesGenerated(int exitCode, QProcess::ExitStatus exitStatus)
356
369
{
357
370
QDir dir (currentImagesFolder);
358
371
359
- auto addItem = [&] (QString item, QString filename)
360
- {
361
- for (const QFileInfo& image : dir.entryInfoList ())
362
- {
363
- if (image.baseName ().contains (filename))
364
- {
365
- imagesFilename.append (image.absoluteFilePath ());
366
- ui->imageComboBox ->addItem (item);
367
- break ;
368
- }
369
- }
370
- };
371
-
372
372
if (vectorial)
373
373
dir.setNameFilters (QStringList () << " *.svg" );
374
374
else
@@ -379,17 +379,17 @@ void MainWindow::imagesGenerated(int exitCode, QProcess::ExitStatus exitStatus)
379
379
imagesFilename.clear ();
380
380
ui->imageComboBox ->clear ();
381
381
382
- addItem ( tr (" Processed front" ), " processed_front" );
383
- addItem ( tr (" Processed back" ), " processed_back" );
384
- addItem ( tr (" Processed outline" ), " processed_outline" );
385
- addItem ( tr (" Traced front" ), " traced_front" );
386
- addItem ( tr (" Traced back" ), " traced_back" );
387
- addItem ( tr (" Masked front" ), " masked_front" );
388
- addItem ( tr (" Masked back" ), " masked_back" );
389
- addItem ( tr (" Input front" ), " original_front" );
390
- addItem ( tr (" Input back" ), " original_back" );
391
- addItem ( tr (" Input drill" ), " original_drill" );
392
- addItem ( tr (" Input outline" ), fillOutline ? " outline_filled" : " original_outline" );
382
+ addImageFile (dir, tr (" Processed front" ), " processed_front" );
383
+ addImageFile (dir, tr (" Processed back" ), " processed_back" );
384
+ addImageFile (dir, tr (" Processed outline" ), " processed_outline" );
385
+ addImageFile (dir, tr (" Traced front" ), " traced_front" );
386
+ addImageFile (dir, tr (" Traced back" ), " traced_back" );
387
+ addImageFile (dir, tr (" Masked front" ), " masked_front" );
388
+ addImageFile (dir, tr (" Masked back" ), " masked_back" );
389
+ addImageFile (dir, tr (" Input front" ), " original_front" );
390
+ addImageFile (dir, tr (" Input back" ), " original_back" );
391
+ addImageFile (dir, tr (" Input drill" ), " original_drill" );
392
+ addImageFile (dir, tr (" Input outline" ), fillOutline ? " outline_filled" : " original_outline" );
393
393
}
394
394
else
395
395
{
@@ -422,7 +422,7 @@ void MainWindow::showImage(QString image)
422
422
{
423
423
const bool wasEmpty = scene.items ().isEmpty ();
424
424
425
- for (QGraphicsItem *item : scene.items ())
425
+ foreach (QGraphicsItem *item, scene.items ())
426
426
{
427
427
scene.removeItem (item);
428
428
delete item;
@@ -925,7 +925,7 @@ void MainWindow::clearImages()
925
925
dir.setNameFilters (QStringList () << " *.*" );
926
926
dir.setFilter (QDir::Files);
927
927
928
- for (const QString& dirFile : dir.entryList ())
928
+ foreach (const QString& dirFile, dir.entryList ())
929
929
{
930
930
dir.remove (dirFile);
931
931
}
0 commit comments