Skip to content

Commit 280cf3a

Browse files
committed
Remove C++11 dependencies
1 parent 60c96c9 commit 280cf3a

File tree

5 files changed

+36
-34
lines changed

5 files changed

+36
-34
lines changed

argaction.cpp

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -145,7 +145,7 @@ void argBase<QButtonGroup>::setEnabled(bool enabled)
145145
{
146146
QList<QAbstractButton *> buttons = object->buttons();
147147

148-
for (QAbstractButton *button : buttons)
148+
foreach (QAbstractButton *button, buttons)
149149
{
150150
button->setEnabled(enabled);
151151
}
@@ -162,7 +162,8 @@ QStringList argAction::getAllArgs(const QString prepend, bool getCommentedOption
162162
QStringList output;
163163
QString value;
164164

165-
for (auto i = objects.constBegin(); i != objects.constEnd(); i++)
165+
for (QMap<QString, argBaseVirtual *>::const_iterator i = objects.constBegin();
166+
i != objects.constEnd(); i++)
166167
{
167168
value = i.value()->getValue();
168169
if ( !value.isEmpty() )

argaction.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -89,7 +89,7 @@ class argAction {
8989

9090
inline bool setValue(const QString key, const QString value)
9191
{
92-
auto pos = objects.find(key);
92+
QMap<QString, argBaseVirtual *>::iterator pos = objects.find(key);
9393

9494
if (pos != objects.end())
9595
return (*pos)->setValue(value);

mainwindow.cpp

Lines changed: 30 additions & 30 deletions
Original file line numberDiff line numberDiff line change
@@ -214,7 +214,7 @@ void MainWindow::checkPcb2gcodeVersion()
214214
QStringList versionSplit = pcb2gcodeVersion.split('.');
215215
QVector<int> versionNumbers;
216216

217-
for (const QString& str : versionSplit)
217+
foreach (const QString& str, versionSplit)
218218
{
219219
versionNumbers.append(str.toInt());
220220
}
@@ -323,11 +323,11 @@ void MainWindow::generateImages()
323323

324324
arguments += getCmdLineArguments();
325325

326-
for (QString& option : arguments)
326+
for (QStringList::iterator i = arguments.begin(); i != arguments.end(); i++)
327327
{
328-
if (option.startsWith("--output-dir"))
328+
if (i->startsWith("--output-dir"))
329329
{
330-
option = "--output-dir=" + imagesFolder;
330+
*i = "--output-dir=" + imagesFolder;
331331
found_output_dir = true;
332332
break;
333333
}
@@ -347,6 +347,19 @@ void MainWindow::generateImages()
347347
pcb2gcodeImageProcess.start(PCB2GCODE_EXECUTABLE, arguments, QProcess::ReadOnly);
348348
}
349349

350+
void MainWindow::addImageFile(const QDir& dir, const QString& item, const QString& filename)
351+
{
352+
foreach (const QFileInfo& image, dir.entryInfoList())
353+
{
354+
if (image.baseName().contains(filename))
355+
{
356+
imagesFilename.append(image.absoluteFilePath());
357+
ui->imageComboBox->addItem(item);
358+
break;
359+
}
360+
}
361+
}
362+
350363
void MainWindow::imagesGenerated(int exitCode, QProcess::ExitStatus exitStatus)
351364
{
352365
loadingIcon.stop();
@@ -356,19 +369,6 @@ void MainWindow::imagesGenerated(int exitCode, QProcess::ExitStatus exitStatus)
356369
{
357370
QDir dir(currentImagesFolder);
358371

359-
auto addItem = [&] (QString item, QString filename)
360-
{
361-
for (const QFileInfo& image : dir.entryInfoList())
362-
{
363-
if (image.baseName().contains(filename))
364-
{
365-
imagesFilename.append(image.absoluteFilePath());
366-
ui->imageComboBox->addItem(item);
367-
break;
368-
}
369-
}
370-
};
371-
372372
if (vectorial)
373373
dir.setNameFilters(QStringList() << "*.svg");
374374
else
@@ -379,17 +379,17 @@ void MainWindow::imagesGenerated(int exitCode, QProcess::ExitStatus exitStatus)
379379
imagesFilename.clear();
380380
ui->imageComboBox->clear();
381381

382-
addItem(tr("Processed front"), "processed_front");
383-
addItem(tr("Processed back"), "processed_back");
384-
addItem(tr("Processed outline"), "processed_outline");
385-
addItem(tr("Traced front"), "traced_front");
386-
addItem(tr("Traced back"), "traced_back");
387-
addItem(tr("Masked front"), "masked_front");
388-
addItem(tr("Masked back"), "masked_back");
389-
addItem(tr("Input front"), "original_front");
390-
addItem(tr("Input back"), "original_back");
391-
addItem(tr("Input drill"), "original_drill");
392-
addItem(tr("Input outline"), fillOutline ? "outline_filled" : "original_outline");
382+
addImageFile(dir, tr("Processed front"), "processed_front");
383+
addImageFile(dir, tr("Processed back"), "processed_back");
384+
addImageFile(dir, tr("Processed outline"), "processed_outline");
385+
addImageFile(dir, tr("Traced front"), "traced_front");
386+
addImageFile(dir, tr("Traced back"), "traced_back");
387+
addImageFile(dir, tr("Masked front"), "masked_front");
388+
addImageFile(dir, tr("Masked back"), "masked_back");
389+
addImageFile(dir, tr("Input front"), "original_front");
390+
addImageFile(dir, tr("Input back"), "original_back");
391+
addImageFile(dir, tr("Input drill"), "original_drill");
392+
addImageFile(dir, tr("Input outline"), fillOutline ? "outline_filled" : "original_outline");
393393
}
394394
else
395395
{
@@ -422,7 +422,7 @@ void MainWindow::showImage(QString image)
422422
{
423423
const bool wasEmpty = scene.items().isEmpty();
424424

425-
for (QGraphicsItem *item : scene.items())
425+
foreach (QGraphicsItem *item, scene.items())
426426
{
427427
scene.removeItem(item);
428428
delete item;
@@ -925,7 +925,7 @@ void MainWindow::clearImages()
925925
dir.setNameFilters(QStringList() << "*.*");
926926
dir.setFilter(QDir::Files);
927927

928-
for (const QString& dirFile : dir.entryList())
928+
foreach (const QString& dirFile, dir.entryList())
929929
{
930930
dir.remove(dirFile);
931931
}

mainwindow.h

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -67,6 +67,7 @@ private slots:
6767
void generateImages();
6868
void imagesGenerated(int exitCode, QProcess::ExitStatus exitStatus);
6969
void imageSelected(int index);
70+
void addImageFile(const QDir& dir, const QString& item, const QString& filename);
7071

7172
void getFrontFile();
7273
void getBackFile();

settings.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -51,7 +51,7 @@ static const QString excellon_file_filter = "Excellon files (*.drl *.drd *.dri *
5151
static const QString gcode_file_filter = "G-Code files (*.nc *.cnc *.ncc *.ecs *.ngc *.fan *.hnc);;All types (*.*)";
5252
static const QString text_file_filter = "Text files (*.*)";
5353

54-
static const QVector<int> targetVersion = {1, 3, 2};
54+
static const QVector<int> targetVersion(QVector<int>() << 1 << 3 << 2);
5555

5656
#endif // SETTINGS
5757

0 commit comments

Comments
 (0)