Skip to content

[BUG]: Fails to compile on php 8.5 #16808

@akansc

Description

@akansc

Describe the bug

Fails to compile on 8.5 due to missing ext/standard/php_smart_string.h

The 8.4 already had the deprecation message and got removed in 8.5 completely.

php-8.4.12.tar.gz# tail -n2 ./ext/standard/php_smart_string.h
/* Header moved to Zend. This file is retained for BC. */
#include "zend_smart_string.h"

Error:

Generating files
configure: creating build directories
configure: creating Makefile
configure: patching config.h.in
configure: creating ./config.status
config.status: creating config.h
/bin/bash /usr/local/directadmin/custombuild/tmp/tmp.3k5NfMhEt8.phalcon-pecl-5.9.3.tgz/libtool --tag=CC --mode=compile cc -I. -I/usr/local/directadmin/custombuild/tmp/tmp.3k5NfM
hEt8.phalcon-pecl-5.9.3.tgz -I/usr/local/php85/include/php -I/usr/local/php85/include/php/main -I/usr/local/php85/include/php/TSRM -I/usr/local/php85/include/php/Zend -I/usr/loc
al/php85/include/php/ext -I/usr/local/php85/include/php/ext/date/lib  -DHAVE_CONFIG_H  -fpermissive -D_GNU_SOURCE    -DZEND_COMPILE_DL_EXT=1 -c /usr/local/directadmin/custombuil
d/tmp/tmp.3k5NfMhEt8.phalcon-pecl-5.9.3.tgz/phalcon.zep.c -o phalcon.lo  -MMD -MF phalcon.dep -MT phalcon.lo
mkdir .libs
 cc -I. -I/usr/local/directadmin/custombuild/tmp/tmp.3k5NfMhEt8.phalcon-pecl-5.9.3.tgz -I/usr/local/php85/include/php -I/usr/local/php85/include/php/main -I/usr/local/php85/incl
ude/php/TSRM -I/usr/local/php85/include/php/Zend -I/usr/local/php85/include/php/ext -I/usr/local/php85/include/php/ext/date/lib -DHAVE_CONFIG_H -fpermissive -D_GNU_SOURCE -DZEND
_COMPILE_DL_EXT=1 -c /usr/local/directadmin/custombuild/tmp/tmp.3k5NfMhEt8.phalcon-pecl-5.9.3.tgz/phalcon.zep.c -MMD -MF phalcon.dep -MT phalcon.lo  -fPIC -DPIC -o .libs/phalcon
.o
cc1: warning: command-line option '-fpermissive' is valid for C++/ObjC++ but not for C
/usr/local/directadmin/custombuild/tmp/tmp.3k5NfMhEt8.phalcon-pecl-5.9.3.tgz/phalcon.zep.c:61:10: fatal error: ext/standard/php_smart_string.h: No such file or directory
   61 | #include <ext/standard/php_smart_string.h>
      |          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
compilation terminated.
make: *** [Makefile:208: phalcon.lo] Error 1

To Reproduce

Try to compile the module on php 8.5

Expected behavior

Compile succesfully.

Additional context

Redis already adapted the change:
phpredis/phpredis@9cae781

Imagick
Imagick/imagick@45adfb7

Igbinary:
igbinary/igbinary@73191b3

Metadata

Metadata

Assignees

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions