Skip to content

Unnecessary dependencies #70

@olafdietsche

Description

@olafdietsche

What did you expect to happen?

There should be no dependency to bc, because it isn't used anywhere in the scripts.

What actually happened?

https://github.com/phenax/bsp-layout/blob/master/src/utils/common.sh aborts, if bc isn't installed.

Describe your attempts to resolve the issue

Nothing done so far.

Steps to reproduce

  1. Uninstall bc or rename bc, e.g. mv /usr/bin/bc /usr/bin/bc.off
  2. Run bsp-layout
  3. bsp-layout aborts with "[Missing dependency] bsp-layout needs bc installed"
  4. Don't forget to reinstall bc or revert the renaming: mv /usr/bin/bc.off /usr/bin/bc

System Information

I installed the bsp-layout command with make DESTDIR=/tmp/destdir install.

$ uname -osrm
Linux 5.15.0-56-generic x86_64 GNU/Linux
$ /tmp/destdir/usr/local/bin/bsp-layout version
0.0.10-1

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't workingneeds-triageNeeds more investigation to determine the priority

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions