More sniffs.

Author: dereuromark

PhpCollective/Sniffs/Classes/MethodArgumentDefaultValueSniff.php

@@ -147,11 +147,9 @@ protected function removeDefaultArgument(File $phpcsFile, int $startIndex, int $
      */
     protected function isTypehintedNullableVariable(File $phpcsFile, int $index): bool
     {
-        $tokens = $phpcsFile->getTokens();
-
-        $nextIndex = $phpcsFile->findNext(Tokens::$emptyTokens, $index + 1, null, true);
-
-        $nextToken = $tokens[$nextIndex];
+        //$tokens = $phpcsFile->getTokens();
+        //$nextIndex = $phpcsFile->findNext(Tokens::$emptyTokens, $index + 1, null, true);
+        //$nextToken = $tokens[$nextIndex];
 
         /*
         if (!$nextToken->equals([T_STRING, 'null'], false)) {

PhpCollective/Sniffs/Commenting/DocBlockTagIterableSniff.php

@@ -40,7 +40,7 @@ public function process(File $phpcsFile, $stackPtr): void
 
         $tag = $content;
         if (str_contains($tag, ' ')) {
-            [$tag, $description] = explode(' ', $content, 2);
+            [$tag] = explode(' ', $content, 2);
         }
 
         if (!preg_match('#^@(?:[a-z]+-)?(?:param|return|var)\b#i', $tag)) {

PhpCollective/Sniffs/Commenting/DocCommentSniff.php

@@ -128,12 +128,10 @@ public function process(File $phpcsFile, $stackPtr): void
 
         // Account for the fact that a short description might cover
         // multiple lines.
-        $shortContent = $tokens[$short]['content'];
         $shortEnd = $short;
         for ($i = ($short + 1); $i < $commentEnd; $i++) {
             if ($tokens[$i]['code'] === T_DOC_COMMENT_STRING) {
                 if ($tokens[$i]['line'] === ($tokens[$shortEnd]['line'] + 1)) {
-                    $shortContent .= $tokens[$i]['content'];
                     $shortEnd = $i;
                 } else {
                     break;

PhpCollective/Sniffs/PHP/ExitSniff.php

@@ -48,8 +48,7 @@ public function process(File $phpcsFile, $stackPtr): void
      */
     protected function checkExitUsage(File $phpcsFile, int $stackPtr): void
     {
-        $wrongTokens = [T_FUNCTION, T_OBJECT_OPERATOR, T_NEW, T_DOUBLE_COLON];
-
+        //$wrongTokens = [T_FUNCTION, T_OBJECT_OPERATOR, T_NEW, T_DOUBLE_COLON];
         $tokens = $phpcsFile->getTokens();
 
         $tokenContent = $tokens[$stackPtr]['content'];

PhpCollective/ruleset.xml

@@ -71,6 +71,9 @@
     <rule ref="SlevomatCodingStandard.TypeHints.NullableTypeForNullDefaultValue"/>
     <rule ref="SlevomatCodingStandard.TypeHints.LongTypeHints"/>
 
+    <rule ref="SlevomatCodingStandard.Attributes.AttributeAndTargetSpacing"/>
+    <rule ref="SlevomatCodingStandard.Attributes.RequireAttributeAfterDocComment"/>
+
     <rule ref="SlevomatCodingStandard.Classes.BackedEnumTypeSpacing"/>
     <rule ref="SlevomatCodingStandard.Classes.EnumCaseSpacing"/>
     <rule ref="SlevomatCodingStandard.Classes.ConstantSpacing">
@@ -90,6 +93,7 @@
     <rule ref="SlevomatCodingStandard.ControlStructures.AssignmentInCondition"/>
 
     <rule ref="SlevomatCodingStandard.Variables.DuplicateAssignmentToVariable"/>
+    <rule ref="SlevomatCodingStandard.Variables.UnusedVariable"/>
 
     <rule ref="SlevomatCodingStandard.PHP.UselessSemicolon"/>
     <rule ref="SlevomatCodingStandard.PHP.ShortList"/>
@@ -114,6 +118,7 @@
     <rule ref="SlevomatCodingStandard.ControlStructures.DisallowContinueWithoutIntegerOperandInSwitch"/>
     <rule ref="SlevomatCodingStandard.ControlStructures.DisallowYodaComparison"/>
     <rule ref="SlevomatCodingStandard.ControlStructures.JumpStatementsSpacing"/>
+    <rule ref="SlevomatCodingStandard.ControlStructures.LanguageConstructWithParentheses"/>
     <rule ref="SlevomatCodingStandard.PHP.ForbiddenClasses"/>
     <rule ref="SlevomatCodingStandard.Classes.ClassMemberSpacing"/>
 
@@ -202,6 +207,7 @@
     <rule ref="Squiz.PHP.Eval"/>
     <rule ref="Generic.PHP.ForbiddenFunctions"/>
     <rule ref="Squiz.PHP.NonExecutableCode"/>
+    <rule ref="Squiz.PHP.DisallowSizeFunctionsInLoops"/>
     <rule ref="Generic.PHP.NoSilencedErrors"/>
     <rule ref="Generic.PHP.LowerCaseConstant"/>
     <rule ref="SlevomatCodingStandard.PHP.TypeCast"/>

docs/sniffs.md

@@ -1,7 +1,7 @@
 # PhpCollective Code Sniffer
 
 
-The PhpCollectiveStrict standard contains 217 sniffs
+The PhpCollectiveStrict standard contains 226 sniffs
 
 Generic (25 sniffs)
 -------------------
@@ -165,12 +165,14 @@ PSR12 (14 sniffs)
 - PSR12.Properties.ConstantVisibility
 - PSR12.Traits.UseDeclaration
 
-SlevomatCodingStandard (48 sniffs)
+SlevomatCodingStandard (56 sniffs)
 ----------------------------------
 - SlevomatCodingStandard.Arrays.ArrayAccess
 - SlevomatCodingStandard.Arrays.MultiLineArrayEndBracketPlacement
 - SlevomatCodingStandard.Arrays.SingleLineArrayWhitespace
 - SlevomatCodingStandard.Arrays.TrailingArrayComma
+- SlevomatCodingStandard.Attributes.AttributeAndTargetSpacing
+- SlevomatCodingStandard.Attributes.RequireAttributeAfterDocComment
 - SlevomatCodingStandard.Classes.BackedEnumTypeSpacing
 - SlevomatCodingStandard.Classes.ClassConstantVisibility
 - SlevomatCodingStandard.Classes.ClassMemberSpacing
@@ -185,14 +187,19 @@ SlevomatCodingStandard (48 sniffs)
 - SlevomatCodingStandard.ControlStructures.DisallowContinueWithoutIntegerOperandInSwitch
 - SlevomatCodingStandard.ControlStructures.DisallowYodaComparison
 - SlevomatCodingStandard.ControlStructures.JumpStatementsSpacing
+- SlevomatCodingStandard.ControlStructures.LanguageConstructWithParentheses
 - SlevomatCodingStandard.ControlStructures.NewWithParentheses
 - SlevomatCodingStandard.ControlStructures.RequireNullCoalesceOperator
 - SlevomatCodingStandard.ControlStructures.RequireShortTernaryOperator
 - SlevomatCodingStandard.Exceptions.DeadCatch
 - SlevomatCodingStandard.Functions.ArrowFunctionDeclaration
+- SlevomatCodingStandard.Functions.DisallowTrailingCommaInCall
+- SlevomatCodingStandard.Functions.DisallowTrailingCommaInClosureUse
+- SlevomatCodingStandard.Functions.DisallowTrailingCommaInDeclaration
 - SlevomatCodingStandard.Functions.NamedArgumentSpacing
 - SlevomatCodingStandard.Functions.RequireTrailingCommaInCall
 - SlevomatCodingStandard.Functions.RequireTrailingCommaInClosureUse
+- SlevomatCodingStandard.Functions.RequireTrailingCommaInDeclaration
 - SlevomatCodingStandard.Namespaces.AlphabeticallySortedUses
 - SlevomatCodingStandard.Namespaces.FullyQualifiedClassNameInAnnotation
 - SlevomatCodingStandard.Namespaces.NamespaceDeclaration
@@ -214,9 +221,10 @@ SlevomatCodingStandard (48 sniffs)
 - SlevomatCodingStandard.TypeHints.ReturnTypeHintSpacing
 - SlevomatCodingStandard.TypeHints.UnionTypeHintFormat
 - SlevomatCodingStandard.Variables.DuplicateAssignmentToVariable
+- SlevomatCodingStandard.Variables.UnusedVariable
 - SlevomatCodingStandard.Whitespaces.DuplicateSpaces
 
-Squiz (27 sniffs)
+Squiz (28 sniffs)
 -----------------
 - Squiz.Arrays.ArrayBracketSpacing
 - Squiz.Classes.LowercaseClassKeywords
@@ -231,6 +239,7 @@ Squiz (27 sniffs)
 - Squiz.Functions.LowercaseFunctionKeywords
 - Squiz.Functions.MultiLineFunctionDeclaration
 - Squiz.Operators.ValidLogicalOperators
+- Squiz.PHP.DisallowSizeFunctionsInLoops
 - Squiz.PHP.Eval
 - Squiz.PHP.NonExecutableCode
 - Squiz.Scope.MemberVarScope