Fix multi processing of expr in Pre/Post Inc/Dec

Author: ondrejmirtes

src/Analyser/NodeScopeResolver.php

@@ -3900,27 +3900,25 @@ static function (): void {
 			|| $expr instanceof Expr\PreDec
 			|| $expr instanceof Expr\PostDec
 		) {
-			$result = $this->processExprNode($stmt, $expr->var, $scope, $nodeCallback, $context->enterDeep());
-			$scope = $result->getScope();
-			$hasYield = $result->hasYield();
-			$throwPoints = $result->getThrowPoints();
-			$impurePoints = $result->getImpurePoints();
-			$isAlwaysTerminating = $result->isAlwaysTerminating();
-
 			$newExpr = $expr;
 			if ($expr instanceof Expr\PostInc) {
 				$newExpr = new Expr\PreInc($expr->var);
 			} elseif ($expr instanceof Expr\PostDec) {
 				$newExpr = new Expr\PreDec($expr->var);
 			}
 
-			$scope = $this->processVirtualAssign(
+			$result = $this->processVirtualAssign(
 				$scope,
 				$stmt,
 				$expr->var,
 				$newExpr,
 				$nodeCallback,
-			)->getScope();
+			);
+			$scope = $result->getScope();
+			$hasYield = $result->hasYield();
+			$throwPoints = $result->getThrowPoints();
+			$impurePoints = $result->getImpurePoints();
+			$isAlwaysTerminating = $result->isAlwaysTerminating();
 		} elseif ($expr instanceof Ternary) {
 			$ternaryCondResult = $this->processExprNode($stmt, $expr->cond, $scope, $nodeCallback, $context->enterDeep());
 			$throwPoints = $ternaryCondResult->getThrowPoints();

tests/PHPStan/Rules/Pure/PureMethodRuleTest.php

@@ -157,10 +157,6 @@ public function testPureConstructor(): void
 	{
 		$this->treatPhpDocTypesAsCertain = true;
 		$this->analyse([__DIR__ . '/data/pure-constructor.php'], [
-			[
-				'Impure static property access in pure method PureConstructor\Foo::__construct().',
-				19,
-			],
 			[
 				'Impure property assignment in pure method PureConstructor\Foo::__construct().',
 				19,