don't clean properties hash while it is iterated, fixes #316

stesie · stesie · commit 1b7c593bbe1d · 2017-06-08T23:18:52.000+02:00
diff --git a/v8js_v8object_class.cc b/v8js_v8object_class.cc
@@ -224,7 +224,7 @@ static HashTable *v8js_v8object_get_properties(zval *object) /* {{{ */
 			 * it (instead of crashing the engine). */
 			return obj->properties;
 		}
-	} else {
+	} else if (!obj->properties->u.v.nIteratorsCount) {
 		zend_hash_clean(obj->properties);
 	}
 

Original file line number	Diff line number	Diff line change
`@@ -224,7 +224,7 @@ static HashTable v8js_v8object_get_properties(zval object) /* {{{ */`
`224`	`224`	`* it (instead of crashing the engine). */`
`225`	`225`	`return obj->properties;`
`226`	`226`	`}`
`227`		`- } else {`
	`227`	`+ } else if (!obj->properties->u.v.nIteratorsCount) {`
`228`	`228`	`zend_hash_clean(obj->properties);`
`229`	`229`	`}`
`230`	`230`