Skip to content

Commit 313ad1e

Browse files
committed
cleanup: remove no longer needed modules_base from ctx, refs #349
1 parent e8fe553 commit 313ad1e

File tree

3 files changed

+0
-5
lines changed

3 files changed

+0
-5
lines changed

v8js_class.cc

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -200,7 +200,6 @@ static void v8js_free_storage(zend_object *object) /* {{{ */
200200
}
201201

202202
c->modules_stack.~vector();
203-
c->modules_base.~vector();
204203

205204
zval_ptr_dtor(&c->zval_snapshot_blob);
206205

@@ -226,7 +225,6 @@ static zend_object* v8js_new(zend_class_entry *ce) /* {{{ */
226225
new(&c->array_tmpl) v8::Persistent<v8::FunctionTemplate>();
227226

228227
new(&c->modules_stack) std::vector<char*>();
229-
new(&c->modules_base) std::vector<char*>();
230228
new(&c->modules_loaded) std::map<char *, v8js_persistent_value_t, cmp_str>;
231229

232230
new(&c->template_cache) std::map<const zend_string *,v8js_function_tmpl_t>();

v8js_class.h

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -57,7 +57,6 @@ struct v8js_ctx {
5757
zval module_loader;
5858

5959
std::vector<char *> modules_stack;
60-
std::vector<char *> modules_base;
6160
std::map<char *, v8js_persistent_value_t, cmp_str> modules_loaded;
6261
std::map<const zend_string *,v8js_function_tmpl_t> template_cache;
6362

v8js_methods.cc

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -472,7 +472,6 @@ V8JS_METHOD(require)
472472

473473
// Add this module and path to the stack
474474
c->modules_stack.push_back(normalised_module_id);
475-
c->modules_base.push_back(normalised_path);
476475

477476
// Run script to evaluate closure
478477
v8::Local<v8::Value> module_function = script->Run();
@@ -501,7 +500,6 @@ V8JS_METHOD(require)
501500

502501
// Remove this module and path from the stack
503502
c->modules_stack.pop_back();
504-
c->modules_base.pop_back();
505503

506504
efree(normalised_path);
507505

0 commit comments

Comments
 (0)