Skip to content

Commit 42e907c

Browse files
authored
Merge pull request #365 from Jan-E/appveyor_3_tests
Appveyor enable 3 extra tests
2 parents 4762dd1 + 61f98e2 commit 42e907c

File tree

2 files changed

+5
-7
lines changed

2 files changed

+5
-7
lines changed

appveyor.yml

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -41,6 +41,10 @@ install:
4141
- cd deps
4242
- curl -fSL -o %V8_ASSETS% "https://s3.amazonaws.com/win-phpv8/%V8_ASSETS%"
4343
- 7z.exe x %V8_ASSETS%
44+
- curl -fSL -o libiconv.zip "https://windows.php.net/downloads/php-sdk/deps/vc14/%Platform%/libiconv-1.15-vc14-%Platform%.zip"
45+
- 7z.exe x libiconv.zip -y
46+
- curl -fSL -o libxml2.zip "https://windows.php.net/downloads/php-sdk/deps/vc14/%Platform%/libxml2-2.9.8-vc14-%Platform%.zip"
47+
- 7z.exe x libxml2.zip -y
4448
- cd ..
4549
- curl -fSL -o "php-%PHP_VERSION%.tar.gz" "https://github.com/php/php-src/archive/php-%PHP_VERSION%.tar.gz"
4650
- ren php php-src-php-%PHP_VERSION%
@@ -68,7 +72,7 @@ build_script:
6872
- echo Building PHP [%PHP_VERSION%]
6973
- '%PHP_SDK%\bin\phpsdk_setvars'
7074
- buildconf
71-
- configure --disable-all --enable-cli --with-v8js %CONFIGURE_EXTRA%
75+
- configure --disable-all --enable-cli --with-iconv=yes --with-libxml=yes --with-dom=yes --enable-json=static --with-v8js %CONFIGURE_EXTRA%
7276
- nmake
7377

7478
after_build:

tests/extensions_error.phpt

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -9,12 +9,6 @@ phpinfo(INFO_MODULES);
99
$minfo = ob_get_contents();
1010
ob_end_clean();
1111

12-
if(strtoupper(substr(PHP_OS, 0, 3)) == 'WIN') {
13-
// On Windows the "Fatal error" happens to appear before the error
14-
// message output by V8 itself.
15-
echo "skip Windows";
16-
}
17-
1812
if(preg_match("/V8 Engine Linked Version => (.*)/", $minfo, $matches)) {
1913
$version = explode('.', $matches[1]);
2014
if($version[0] < 5 || ($version[0] == 5 && $version[1] < 7)) {

0 commit comments

Comments
 (0)