Merge branch 'pioarduino' into develop

Author: Jason2866

.github/workflows/core.yml

@@ -31,6 +31,10 @@ jobs:
         run: |
           tox -e py
 
+      - name: Python Lint
+        run: |
+          tox -e lint
+
       - name: Integration Tests
         if: ${{ matrix.python-version == '3.11' }}
         run: |

.github/workflows/examples.yml

@@ -8,26 +8,11 @@ jobs:
       fail-fast: false
       matrix:
         project:
-          - marlin:
-            repository: "MarlinFirmware/Marlin"
-            folder: "Marlin"
-            config_dir: "Marlin"
-            env_name: "mega2560"
-          - smartknob:
-            repository: "scottbez1/smartknob"
-            folder: "smartknob"
-            config_dir: "smartknob"
-            env_name: "view"
-          - espurna:
-            repository: "xoseperez/espurna"
-            folder: "espurna"
-            config_dir: "espurna/code"
-            env_name: "nodemcu-lolin"
-          - OpenMQTTGateway:
-            repository: "1technophile/OpenMQTTGateway"
-            folder: "OpenMQTTGateway"
-            config_dir: "OpenMQTTGateway"
-            env_name: "esp32-m5atom-lite"
+          - PlatformTest:
+            repository: "Jason2866/platform-test"
+            folder: "src"
+            config_dir: "src"
+            env_name: "esp32-s3"
         os: [ubuntu-latest, windows-latest, macos-latest]
 
     runs-on: ${{ matrix.os }}
@@ -37,7 +22,7 @@ jobs:
           submodules: "recursive"
 
       - name: Set up Python ${{ matrix.python-version }}
-        uses: actions/setup-python@v4
+        uses: actions/setup-python@v5
         with:
           python-version: 3.11
 
@@ -51,6 +36,6 @@ jobs:
           repository: ${{ matrix.project.repository }}
           path: ${{ matrix.project.folder }}
 
-      - name: Compile ${{ matrix.project.repository }}
-        run: pio run -d ${{ matrix.project.config_dir }} -e ${{ matrix.project.env_name }}
-
+      - name: Compile example ${{ matrix.project.repository }}
+        run: |
+          pio run -d ${{ matrix.project.config_dir }} -e ${{ matrix.project.env_name }}

.github/workflows/projects.yml

@@ -10,3 +10,4 @@ coverage.xml
 .coverage
 htmlcov
 .pytest_cache
+.vscode/settings.json

.gitignore

@@ -82,13 +82,11 @@ Contributing
 
 See `contributing guidelines <https://github.com/platformio/platformio/blob/develop/CONTRIBUTING.md>`_.
 
-Telemetry / Privacy Policy
---------------------------
+Telemetry
+---------
 
-Share minimal diagnostics and usage information to help us make PlatformIO better.
-It is enabled by default. For more information see:
+Removed
 
-* `Telemetry Setting <https://docs.platformio.org/en/latest/userguide/cmd_settings.html?utm_source=github&utm_medium=core#enable-telemetry>`_
 
 License
 -------

README.rst

@@ -106,7 +106,6 @@ def main(argv=None):
             exit_code = int(exc.code)
     except Exception as exc:  # pylint: disable=broad-except
         if not isinstance(exc, exception.ReturnErrorCode):
-            maintenance.on_platformio_exception(exc)
             error_str = f"{exc.__class__.__name__}: "
             if isinstance(exc, exception.PlatformioException):
                 error_str += str(exc)
@@ -131,7 +130,6 @@ def main(argv=None):
             click.secho(error_str, fg="red", err=True)
         exit_code = int(str(exc)) if str(exc).isdigit() else 1
 
-    maintenance.on_platformio_exit()
     sys.argv = prev_sys_argv
     return exit_code
 

platformio/__main__.py

@@ -46,10 +46,6 @@ def projects_dir_validate(projects_dir):
         "description": "Enable caching for HTTP API requests",
         "value": True,
     },
-    "enable_telemetry": {
-        "description": ("Telemetry service <https://bit.ly/pio-telemetry> (Yes/No)"),
-        "value": True,
-    },
     "force_verbose": {
         "description": "Force verbose output when processing environments",
         "value": False,
@@ -69,7 +65,6 @@ def projects_dir_validate(projects_dir):
     "command_ctx": None,
     "caller_id": None,
     "custom_project_conf": None,
-    "pause_telemetry": False,
 }
 
 
@@ -274,8 +269,6 @@ def get_user_agent():
         data.append("IDE/%s" % os.getenv("PLATFORMIO_IDE"))
     data.append("Python/%s" % platform.python_version())
     data.append("Platform/%s" % platform.platform())
-    if not get_setting("enable_telemetry"):
-        data.append("Telemetry/0")
     return " ".join(data)
 
 

platformio/app.py

@@ -16,10 +16,8 @@
 import signal
 import time
 
-from platformio import telemetry
 from platformio.compat import aio_get_running_loop, is_bytes
 from platformio.debug import helpers
-from platformio.debug.exception import DebugInitError
 from platformio.debug.process.client import DebugClientProcess
 
 
@@ -130,7 +128,6 @@ def stdout_data_received(self, data):
         self._handle_error(data)
         # go to init break automatically
         if self.INIT_COMPLETED_BANNER.encode() in data:
-            telemetry.log_debug_started(self.debug_config)
             self._auto_exec_continue()
 
     def console_log(self, msg):
@@ -175,7 +172,4 @@ def _handle_error(self, data):
             and b"Error in sourced" in self._errors_buffer
         ):
             return
-        telemetry.log_debug_exception(
-            DebugInitError(self._errors_buffer.decode()), self.debug_config
-        )
         self.transport.close()

platformio/debug/process/gdb.py

@@ -17,12 +17,7 @@
 
 def get_core_dependencies():
     return {
-        "contrib-piohome": "~3.4.2",
-        "contrib-pioremote": "~1.0.0",
-        "tool-scons": "~4.40801.0",
-        "tool-cppcheck": "~1.21100.0",
-        "tool-clangtidy": "~1.150005.0",
-        "tool-pvs-studio": "~7.18.0",
+        "tool-scons",
     }
 
 
@@ -37,6 +32,8 @@ def get_pip_dependencies():
         "requests%s == 2.*" % ("[socks]" if is_proxy_set(socks=True) else ""),
         "semantic_version == 2.10.*",
         "tabulate == 0.*",
+        "intelhex",  # actual esptool.py requirement
+        "argcomplete >=3", # latest esptool.py requirement
     ]
 
     home = [

platformio/dependencies.py

@@ -19,7 +19,7 @@
 import click
 import semantic_version
 
-from platformio import __version__, app, exception, fs, telemetry
+from platformio import __version__, app, exception, fs
 from platformio.cache import cleanup_content_cache
 from platformio.cli import PlatformioCLI
 from platformio.commands.upgrade import get_latest_version
@@ -32,7 +32,6 @@
 def on_cmd_start(ctx, caller):
     app.set_session_var("command_ctx", ctx)
     set_caller(caller)
-    telemetry.on_cmd_start(ctx)
     if PlatformioCLI.in_silence():
         return
     after_upgrade(ctx)
@@ -57,14 +56,6 @@ def on_cmd_end():
         )
 
 
-def on_platformio_exception(exc):
-    telemetry.log_exception(exc)
-
-
-def on_platformio_exit():
-    telemetry.on_exit()
-
-
 def set_caller(caller=None):
     caller = caller or os.getenv("PLATFORMIO_CALLER")
     if not caller:
@@ -103,7 +94,6 @@ def _appstate_migration(_):
         state_path = app.resolve_state_path("core_dir", "appstate.json")
         if not os.path.isfile(state_path):
             return True
-        app.delete_state_item("telemetry")
         created_at = app.get_state_item("created_at", None)
         if not created_at:
             state_stat = os.stat(state_path)
@@ -160,14 +150,6 @@ def after_upgrade(ctx):
             "PlatformIO has been successfully upgraded to %s!\n" % __version__,
             fg="green",
         )
-        telemetry.log_event(
-            "pio_upgrade_core",
-            {
-                "label": "%s > %s" % (last_version_str, __version__),
-                "from_version": last_version_str,
-                "to_version": __version__,
-            },
-        )
 
     return print_welcome_banner()
 
@@ -183,22 +165,6 @@ def print_welcome_banner():
             click.style("https://github.com/platformio/platformio-core", fg="cyan"),
         )
     )
-    click.echo(
-        "- %s us on LinkedIn to stay up-to-date "
-        "on the latest project news > %s"
-        % (
-            click.style("follow", fg="cyan"),
-            click.style("https://www.linkedin.com/company/platformio/", fg="cyan"),
-        )
-    )
-    if not os.getenv("PLATFORMIO_IDE"):
-        click.echo(
-            "- %s PlatformIO IDE for embedded development > %s"
-            % (
-                click.style("try", fg="cyan"),
-                click.style("https://platformio.org/platformio-ide", fg="cyan"),
-            )
-        )
 
     click.echo("*" * terminal_width)
     click.echo("")