Merge commit 'eebdcacb310ce2a744c4789f089484746fc63328'

Author: Jenkins User

README.md

@@ -228,23 +228,6 @@ pipedrive.Filters.getAll({ type: 'deals' }, function(filtersListErr, filtersList
 });
 ```
 
-# Ad hoc data change event listeneres (beta)
-
-The API client lets you create event listeners to specific data changes in your Pipedrive account. This is very similar to Webhooks, except the listeners are bound on an ad hoc basis and will only be executed during the lifecycle of your application. For example (see below) you may want to execute a callback every time a new deal is added to Pipedrive. Note that this callback will execute not only when you create the deal through this API client but regardless of where the deal was added from — a mobile app, the web app or through the Pipedrive API by some other integration.
-
-```js
-var Pipedrive = require('pipedrive');
-var pipedrive = new Pipedrive.Client('PUT_YOUR_API_TOKEN_HERE', { strictMode: true });
-
-pipedrive.on('deal.added', function(event, data) {
-	console.log('A deal was added! ' + data.current.title + ' (' + data.current.value + ' ' + data.current.currency + ')');
-});
-```
-
-Supported event names consist of object type (deal, person, organization, ...) and type of change (`added`, `deleted`, `updated` or `merged`), joined by a dot. The list of supported object types are listed in the [Pipedrive Webhooks documentation](https://app.pipedrive.com/webhooks).
-
-To read more about ad hoc data change event listeners, check out [examples/live-updates.js](examples/live-updates.js).
-
 # API Documentation
 
 The Pipedrive REST API documentation can be found at https://developers.pipedrive.com/v1

examples/live-updates.js

@@ -12,7 +12,6 @@
 	var _ = require('lodash'),
 		blueprint = require(__dirname + '/blueprint'),
 		inflection = require(__dirname + '/inflection'),
-		Channel = require(__dirname + '/channel'),
 		log = require(__dirname + '/log'),
 		RestHandlers = require(__dirname + '/restHandlers'),
 		Collection = require(__dirname + '/Collection'),
@@ -35,15 +34,7 @@
 		options = _.extend({}, defaults, options);
 		options.strictMode = !!options.strictMode;
 
-		var that = this,
-			listener = new Channel(apiToken);
-
-		if (options.strictMode) {
-			// in strict mode, we'll expose the EventEmitter-like real-time integration methods
-			this.on = listener.on;
-			this.removeListener = listener.removeListener;
-			this.removeAllListeners = listener.removeAllListeners;
-		}
+		var that = this;
 
 		_.each(blueprint.apiObjects, function (item) {
 			that[item.substr(0, 1).toUpperCase() + item.substr(1)] = new Collection(item, _.extend({}, options, {apiToken: apiToken}));

lib/Pipedrive.js

@@ -17,34 +17,6 @@ describe('client', function () {
 		strictClient = new Pipedrive.Client(API_TOKEN, {strictMode: true});
 	});
 
-
-	describe('client.on()', function () {
-		it('should allow event binding to connect and deal adding', function (done) {
-			this.timeout(10000);
-
-			var deal = {title: 'Client-nodejs - .on() test', value: 10000, currency: 'EUR'};
-
-			strictClient.on('connect', function () {
-				strictClient.Deals.add(deal, function (error, result) {
-					deal.id = result.id;
-				});
-			});
-
-			strictClient.on('deal.added', function (event, data) {
-				assert.equal(data.current.title, deal.title);
-				assert.equal(data.current.value, deal.value);
-				assert.equal(data.current.currency, deal.currency);
-
-				strictClient.removeAllListeners();
-
-				//cleanup
-				strictClient.Deals.remove(deal.id, function () {
-					done();
-				});
-			});
-		});
-	});
-
 	describe('collection.getAll()', function () {
 		it('should list filters and deals', function (done) {
 			client.Filters.getAll({type: 'deals'}, function (filtersListErr, filtersList) {

lib/channel.js

@@ -19,16 +19,6 @@ describe('client module', function () {
 		});
 	});
 
-	describe('client.on()', function () {
-		it('should be defined in strict mode', function () {
-			assert.isFunction(strictClient.on);
-		});
-
-		it('should not be defined in regular mode', function () {
-			assert.isUndefined(client.on);
-		});
-	});
-
 	it('client.getAll() should throw error if non-existant resource is requested', function (done) {
 		client.getAll('bananas', function (error) {
 			assert.equal(error.message, 'bananas is not supported object type for getAll()');