IND-524 added functional tests, moved unit tests

Author: tot-ra

README.md

@@ -248,6 +248,13 @@ To read more about ad hoc data change event listeners, check out [examples/live-
 
 The Pipedrive REST API documentation can be found at https://developers.pipedrive.com/v1
 
+#Testing
+To run unit tests, execute `npm run tests`
+
+To run integration tests, you need to provide API token with environment variables:
+
+```export PIPEDRIVE_API_TOKEN='xxxxxx' && npm run test:functional```
+
 # Licence
 
 This Pipedrive API client is distributed under the MIT licence.

package.json

@@ -22,7 +22,8 @@
     "url": "http://github.com/pipedrive/client-nodejs.git"
   },
   "scripts": {
-    "test": "./node_modules/mocha/bin/mocha ./test"
+    "test": "./node_modules/mocha/bin/mocha ./test/unit",
+    "test:functional": "./node_modules/mocha/bin/mocha ./test/functional"
   },
   "dependencies": {
     "async": "~0.9.0",

test/functional/client.js

@@ -0,0 +1,43 @@
+var should = require('should');
+var apiToken = process.env.PIPEDRIVE_API_TOKEN || '';
+
+//fixture — need deal with id 1
+describe('client integration tests', function() {
+
+	it('getting non-existant deal should return error', function(done) {
+		var Pipedrive = require('./../..'),
+			pipedrive = new Pipedrive.Client(apiToken, { strictMode: true });
+
+		pipedrive.Deals.get(99999, function(err, deal) {
+			should.notEqual(err, null);
+			should.equal(err.message, 'Pipedrive API error:Deal not found');
+
+			done();
+		});
+
+		should(pipedrive.on).be.a.Function();
+	});
+
+	it('adding non-existant product to existing deal (with id 1) should return error string in callback', function(done) {
+		var Pipedrive = require('./../..'),
+			pipedrive = new Pipedrive.Client(apiToken, { strictMode: true });
+
+		pipedrive.Deals.get(1, function(err, deal) {
+			should.equal(err, null);
+
+			deal.addProduct({
+				product_id: 999999,
+				quantity: 1,
+				item_price: 0
+			}, function (addErr, addData) {
+
+				should.notEqual(addErr, null);
+				should.equal(addErr.message, 'Pipedrive API error:Product(s) 1 not found.');
+				done();
+			});
+		});
+
+		should(pipedrive.on).be.a.Function();
+	});
+
+});

test/client.js renamed to test/unit/client.js

@@ -3,9 +3,9 @@ var should = require('should');
 describe('client module', function() {
 
 	it('should expose some of the main object types', function() {
-		var Pipedrive = require('./..'),
+		var Pipedrive = require('./../..'),
 			pipedrive = new Pipedrive.Client('apitoken'),
-			blueprint = require('./../lib/blueprint');
+			blueprint = require('./../../lib/blueprint');
 
 		// iterate through all top level objects which should be exposed, e.g. pipedrive.Deals, ...
 		blueprint.apiObjects.forEach(function(obj) {
@@ -14,10 +14,9 @@ describe('client module', function() {
 	});
 
 	it('should expose .on() listener in strict mode', function() {
-		var Pipedrive = require('./..'),
+		var Pipedrive = require('./../..'),
 			pipedrive = new Pipedrive.Client('apitoken', { strictMode: true });
 
 		should(pipedrive.on).be.a.Function();
 	});
-
 });

test/index.js renamed to test/unit/index.js

@@ -3,11 +3,11 @@ var should = require('should');
 describe('main module', function() {
 
 	it('should be requireable without errors', function() {
-		var Pipedrive = require('./..');
+		var Pipedrive = require('./../..');
 	});
 
 	it('should expose top-level functionality', function() {
-		var Pipedrive = require('./..');
+		var Pipedrive = require('./../..');
 
 		should(Pipedrive.Client).be.a.Function();
 		should(Pipedrive.authenticate).be.a.Function();