Skip to content

Commit 4ad3774

Browse files
committed
Fix focus ring clipping in dialog components
1 parent 72de77d commit 4ad3774

File tree

1 file changed

+2
-1
lines changed

1 file changed

+2
-1
lines changed

application/shared-webapp/ui/components/DialogFooter.tsx

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ export function DialogFooter({ children, className }: Readonly<DialogFooterProps
1616
return (
1717
<div
1818
className={twMerge(
19-
"mt-8 flex justify-end gap-4",
19+
"mt-8 flex justify-end gap-4 px-1", // Added px-1 to align with DialogContent padding
2020
"max-sm:fixed max-sm:right-0 max-sm:bottom-0 max-sm:left-0 max-sm:mt-0 max-sm:border-border max-sm:border-t max-sm:bg-background max-sm:p-4 max-sm:shadow-lg",
2121
"max-sm:supports-[padding:max(0px)]:pb-[max(1rem,env(safe-area-inset-bottom))]",
2222
className
@@ -41,6 +41,7 @@ export function DialogContent({ children, className }: Readonly<{ children: Reac
4141
<div
4242
className={twMerge(
4343
"min-h-0 flex-1 overflow-y-auto overflow-x-hidden",
44+
"p-1", // Add padding to prevent focus ring clipping
4445
"max-sm:pb-20", // Add padding to account for fixed footer on mobile
4546
"max-sm:supports-[padding:max(0px)]:pb-[calc(5rem+env(safe-area-inset-bottom))]", // Adjust for safe area
4647
"-webkit-overflow-scrolling-touch",

0 commit comments

Comments
 (0)