Skip to content

Commit a55cd4d

Browse files
authored
Fix scrolling regression introduced by recent AppLayout changes (#780)
### Summary & Motivation Fix the scrolling regression on the landing and authentication pages introduced by recent changes to AppLayout and global styles. The new CSS rules added fixed positioning and overflow:hidden to the html/body elements, which broke scrolling on standalone pages. - Remove fixed positioning and overflow restrictions from html/body elements to restore normal scrolling behavior. - Set minimum height constraint on user table to prevent rows from being hidden on short viewports. - Fix missing translations for toast messages when deleting users. ### Checklist - [x] I have added tests, or done manual regression tests - [x] I have updated the documentation, if necessary
2 parents aa7c463 + 787cc02 commit a55cd4d

File tree

6 files changed

+30
-31
lines changed

6 files changed

+30
-31
lines changed

application/account-management/WebApp/routes/admin/users/-components/DeleteUserDialog.tsx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@ export function DeleteUserDialog({ users, isOpen, onOpenChange, onUsersDeleted }
2828
deleteUserMutation.mutateAsync({ params: { path: { id: user.id } } }).then(() => {
2929
toastQueue.add({
3030
title: t`Success`,
31-
description: `User deleted successfully: ${userDisplayName}`,
31+
description: t`User deleted successfully: ${userDisplayName}`,
3232
variant: "success"
3333
});
3434

@@ -40,7 +40,7 @@ export function DeleteUserDialog({ users, isOpen, onOpenChange, onUsersDeleted }
4040
await bulkDeleteUsersMutation.mutateAsync({ body: { userIds: userIds } }).then(() => {
4141
toastQueue.add({
4242
title: t`Success`,
43-
description: `${users.length} users deleted successfully`,
43+
description: t`${users.length} users deleted successfully`,
4444
variant: "success"
4545
});
4646

application/account-management/WebApp/routes/admin/users/-components/UserTable.tsx

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,6 @@ interface UserTableProps {
3535
isProfileOpen?: boolean;
3636
}
3737

38-
// biome-ignore lint/complexity/noExcessiveCognitiveComplexity: Component handles complex table interactions including sorting, selection, pagination and infinite scroll
3938
export function UserTable({
4039
selectedUsers,
4140
onSelectedUsersChange,
@@ -215,7 +214,7 @@ export function UserTable({
215214

216215
return (
217216
<>
218-
<div className={isMobile ? "flex-1" : "min-h-0 flex-1"}>
217+
<div className="min-h-48 flex-1">
219218
<Table
220219
key={pageOffset}
221220
selectionMode={isTouchDevice() || !isMediumViewportOrLarger() ? "single" : "multiple"}

application/account-management/WebApp/shared/translations/locale/da-DK.po

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,10 @@ msgstr ""
1313
"Plural-Forms: \n"
1414
"X-Generator: @lingui/cli\n"
1515

16+
#. placeholder {0}: users.length
17+
msgid "{0} users deleted successfully"
18+
msgstr "{0} brugere slettet succesfuldt"
19+
1620
msgid "A new verification code has been sent to your email."
1721
msgstr "En ny bekræftelseskode er blevet sendt til din e-mail."
1822

@@ -417,6 +421,9 @@ msgstr "Brugerhandlinger"
417421
msgid "User data updated"
418422
msgstr "Brugerdata opdateret"
419423

424+
msgid "User deleted successfully: {userDisplayName}"
425+
msgstr "Bruger slettet succesfuldt: {userDisplayName}"
426+
420427
msgid "User invited successfully"
421428
msgstr "Bruger inviteret succesfuldt"
422429

application/account-management/WebApp/shared/translations/locale/en-US.po

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,10 @@ msgstr ""
1313
"Plural-Forms: \n"
1414
"X-Generator: @lingui/cli\n"
1515

16+
#. placeholder {0}: users.length
17+
msgid "{0} users deleted successfully"
18+
msgstr "{0} users deleted successfully"
19+
1620
msgid "A new verification code has been sent to your email."
1721
msgstr "A new verification code has been sent to your email."
1822

@@ -417,6 +421,9 @@ msgstr "User actions"
417421
msgid "User data updated"
418422
msgstr "User data updated"
419423

424+
msgid "User deleted successfully: {userDisplayName}"
425+
msgstr "User deleted successfully: {userDisplayName}"
426+
420427
msgid "User invited successfully"
421428
msgstr "User invited successfully"
422429

application/account-management/WebApp/shared/translations/locale/nl-NL.po

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,10 @@ msgstr ""
1313
"Plural-Forms: \n"
1414
"X-Generator: @lingui/cli\n"
1515

16+
#. placeholder {0}: users.length
17+
msgid "{0} users deleted successfully"
18+
msgstr "{0} gebruikers succesvol verwijderd"
19+
1620
msgid "A new verification code has been sent to your email."
1721
msgstr "Een nieuwe verificatiecode is naar je e-mail verzonden."
1822

@@ -417,6 +421,9 @@ msgstr "Gebruikersacties"
417421
msgid "User data updated"
418422
msgstr "Gebruikersgegevens bijgewerkt"
419423

424+
msgid "User deleted successfully: {userDisplayName}"
425+
msgstr "Gebruiker succesvol verwijderd: {userDisplayName}"
426+
420427
msgid "User invited successfully"
421428
msgstr "Gebruiker succesvol uitgenodigd"
422429

application/shared-webapp/ui/tailwind.css

Lines changed: 6 additions & 27 deletions
Original file line numberDiff line numberDiff line change
@@ -118,8 +118,6 @@
118118
-moz-osx-font-smoothing: grayscale;
119119
-webkit-font-smoothing: antialiased;
120120
font-synthesis: none;
121-
height: 100%;
122-
overflow: hidden;
123121
scroll-behavior: smooth;
124122
touch-action: manipulation;
125123
}
@@ -149,40 +147,21 @@
149147
}
150148
}
151149

152-
html {
150+
/* Default styles - allow normal scrolling */
151+
html,
152+
body {
153153
height: 100%;
154-
width: 100%;
155-
padding: 0;
156154
margin: 0;
157-
position: fixed;
158-
top: 0;
159-
left: 0;
160-
right: 0;
161-
bottom: 0;
162-
overflow: hidden;
155+
padding: 0;
163156
}
164157

165158
body {
166-
height: 100%;
167-
width: 100%;
168-
padding: 0;
169-
margin: 0;
170-
overflow: hidden;
171-
position: fixed;
172-
top: 0;
173-
left: 0;
174-
right: 0;
175-
bottom: 0;
176159
-webkit-overflow-scrolling: touch;
177160
}
178161

179162
#root {
180-
position: absolute;
181-
top: 0;
182-
left: 0;
183-
right: 0;
184-
bottom: 0;
185-
overflow: hidden;
163+
min-height: 100%;
164+
height: 100%;
186165
display: flex;
187166
flex-direction: column;
188167
}

0 commit comments

Comments
 (0)