Skip to content

Commit db04896

Browse files
committed
fix hoverlabel.showarrow behavior for individual traces
1 parent 60f5718 commit db04896

File tree

2 files changed

+4
-2
lines changed

2 files changed

+4
-2
lines changed

src/components/fx/calc.js

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -40,6 +40,7 @@ module.exports = function calc(gd) {
4040
fillFn(trace.hoverlabel.font.variant, cd, 'htv');
4141
fillFn(trace.hoverlabel.namelength, cd, 'hnl');
4242
fillFn(trace.hoverlabel.align, cd, 'hta');
43+
fillFn(trace.hoverlabel.showarrow, cd, 'htsa');
4344
}
4445
};
4546

src/components/fx/hover.js

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -913,7 +913,7 @@ function _hover(gd, evt, subplot, noHoverEvent, eventTarget) {
913913

914914
if(!helpers.isUnifiedHover(hovermode)) {
915915
hoverAvoidOverlaps(hoverLabels, rotateLabels, fullLayout, hoverText.commonLabelBoundingBox);
916-
alignHoverText(hoverLabels, rotateLabels, fullLayout._invScaleX, fullLayout._invScaleY, fullLayout.hoverlabel.showarrow);
916+
alignHoverText(hoverLabels, rotateLabels, fullLayout._invScaleX, fullLayout._invScaleY);
917917
} // TODO: tagName hack is needed to appease geo.js's hack of using eventTarget=true
918918
// we should improve the "fx" API so other plots can use it without these hack.
919919
if(eventTarget && eventTarget.tagName) {
@@ -1903,7 +1903,7 @@ function getTextShiftX(hoverLabel) {
19031903
};
19041904
}
19051905

1906-
function alignHoverText(hoverLabels, rotateLabels, scaleX, scaleY, showArrow) {
1906+
function alignHoverText(hoverLabels, rotateLabels, scaleX, scaleY) {
19071907
var pX = function(x) { return x * scaleX; };
19081908
var pY = function(y) { return y * scaleY; };
19091909

@@ -1922,6 +1922,7 @@ function alignHoverText(hoverLabels, rotateLabels, scaleX, scaleY, showArrow) {
19221922
var offsetY = offsets.y;
19231923

19241924
var isMiddle = anchor === 'middle';
1925+
var showArrow = d.trace.hoverlabel.showarrow;
19251926

19261927
var pathStr;
19271928
if(isMiddle) {

0 commit comments

Comments
 (0)