Merge pull request #1230 from pq-code-package/more-warnings

Fix `-Wconversion` warnings

Author: mkannwischer

examples/basic/Makefile

@@ -59,6 +59,7 @@ CFLAGS := \
 	-Werror \
 	-Wpointer-arith \
 	-Wredundant-decls \
+	-Wconversion \
 	-Wno-long-long \
 	-Wno-unknown-pragmas \
 	-Wno-unused-command-line-argument \

examples/basic_deterministic/Makefile

@@ -47,6 +47,7 @@ CFLAGS := \
 	-Werror \
 	-Wpointer-arith \
 	-Wredundant-decls \
+	-Wconversion \
 	-Wno-long-long \
 	-Wno-unknown-pragmas \
 	-Wno-unused-command-line-argument \

examples/bring_your_own_fips202/Makefile

@@ -65,6 +65,7 @@ CFLAGS := \
 	-Wshadow \
 	-Wpointer-arith \
 	-Wredundant-decls \
+	-Wconversion \
 	-Wno-long-long \
 	-Wno-unknown-pragmas \
 	-Wno-unused-command-line-argument \

examples/bring_your_own_fips202/custom_fips202/tiny_sha3/sha3.c

@@ -96,14 +96,14 @@ void sha3_keccakf(uint64_t st[25])
   {
     v = (uint8_t *)&st[i];
     t = st[i];
-    v[0] = t & 0xFF;
-    v[1] = (t >> 8) & 0xFF;
-    v[2] = (t >> 16) & 0xFF;
-    v[3] = (t >> 24) & 0xFF;
-    v[4] = (t >> 32) & 0xFF;
-    v[5] = (t >> 40) & 0xFF;
-    v[6] = (t >> 48) & 0xFF;
-    v[7] = (t >> 56) & 0xFF;
+    v[0] = (uint8_t)(t & 0xFF);
+    v[1] = (uint8_t)((t >> 8) & 0xFF);
+    v[2] = (uint8_t)((t >> 16) & 0xFF);
+    v[3] = (uint8_t)((t >> 24) & 0xFF);
+    v[4] = (uint8_t)((t >> 32) & 0xFF);
+    v[5] = (uint8_t)((t >> 40) & 0xFF);
+    v[6] = (uint8_t)((t >> 48) & 0xFF);
+    v[7] = (uint8_t)((t >> 56) & 0xFF);
   }
 #endif /* __BYTE_ORDER__ != __ORDER_LITTLE_ENDIAN__ */
 }

examples/custom_backend/Makefile

@@ -62,6 +62,7 @@ CFLAGS := \
 	-Werror \
 	-Wpointer-arith \
 	-Wredundant-decls \
+	-Wconversion \
 	-Wno-long-long \
 	-Wno-unknown-pragmas \
 	-Wno-unused-command-line-argument \

examples/monolithic_build/Makefile

@@ -67,6 +67,7 @@ CFLAGS := \
 	-Wshadow \
 	-Wpointer-arith \
 	-Wredundant-decls \
+	-Wconversion \
 	-Wno-long-long \
 	-Wno-unknown-pragmas \
 	-Wno-unused-command-line-argument \
@@ -135,6 +136,6 @@ size: build
 	@$(Q)$(SIZE) $(LIB512_FULL)
 	@$(Q)$(SIZE) $(LIB768_FULL)
 	@$(Q)$(SIZE) $(LIB1024_FULL)
-	
+
 clean:
 	rm -rf $(BUILD_DIR)

examples/monolithic_build_multilevel_native/Makefile

@@ -94,6 +94,7 @@ CFLAGS := \
 	-Wno-long-long \
 	-Wno-unknown-pragmas \
 	-Wredundant-decls \
+	-Wconversion \
 	-Wno-unused-command-line-argument \
 	-fomit-frame-pointer \
 	-std=c99 \
@@ -135,7 +136,7 @@ build: $(BINARY_NAME_FULL)
 run: $(BINARY_NAME_FULL)
 	$(EXEC_WRAPPER) ./$(BINARY_NAME_FULL)
 
-size: build 
+size: build
 	$(Q)echo "=== Size info for binaries $(BINARY_NAME_FULL)==="
 	$(Q)$(SIZE) $(BINARY_NAME_FULL)
 	$(Q)echo " "

examples/monolithic_build_native/Makefile

@@ -68,6 +68,7 @@ CFLAGS := \
 	-Wshadow \
 	-Wpointer-arith \
 	-Wredundant-decls \
+	-Wconversion \
 	-Wno-long-long \
 	-Wno-unknown-pragmas \
 	-Wno-unused-command-line-argument \

examples/multilevel_build/Makefile

@@ -85,6 +85,7 @@ CFLAGS := \
 	-Werror \
 	-Wpointer-arith \
 	-Wredundant-decls \
+	-Wconversion \
 	-Wno-long-long \
 	-Wno-unknown-pragmas \
 	-Wno-unused-command-line-argument \

examples/multilevel_build_native/Makefile

@@ -60,6 +60,7 @@ CFLAGS := \
 	-Werror \
 	-Wpointer-arith \
 	-Wredundant-decls \
+	-Wconversion \
 	-Wno-long-long \
 	-Wno-unknown-pragmas \
 	-Wno-unused-command-line-argument \