Use Header transport by default in DriftNettyClientConfig

Author: sotodel

drift-transport-netty/src/main/java/com/facebook/drift/transport/netty/client/DriftNettyClientConfig.java

@@ -33,7 +33,7 @@
 import java.util.List;
 
 import static com.facebook.drift.transport.netty.codec.Protocol.BINARY;
-import static com.facebook.drift.transport.netty.codec.Transport.FRAMED;
+import static com.facebook.drift.transport.netty.codec.Transport.HEADER;
 import static io.airlift.units.DataSize.Unit.MEGABYTE;
 import static java.util.Objects.requireNonNull;
 import static java.util.concurrent.TimeUnit.DAYS;
@@ -42,7 +42,7 @@
 
 public class DriftNettyClientConfig
 {
-    private Transport transport = FRAMED;
+    private Transport transport = HEADER;
     private Protocol protocol = BINARY;
     private DataSize maxFrameSize = new DataSize(16, MEGABYTE);
 

drift-transport-netty/src/test/java/com/facebook/drift/transport/netty/client/TestDriftNettyClientConfig.java

@@ -44,7 +44,7 @@ public class TestDriftNettyClientConfig
     public void testDefaults()
     {
         assertRecordedDefaults(recordDefaults(DriftNettyClientConfig.class)
-                .setTransport(FRAMED)
+                .setTransport(HEADER)
                 .setProtocol(BINARY)
                 .setConnectTimeout(new Duration(500, MILLISECONDS))
                 .setRequestTimeout(new Duration(10, SECONDS))
@@ -69,7 +69,7 @@ public void testDefaults()
     public void testExplicitPropertyMappings()
     {
         Map<String, String> properties = new ImmutableMap.Builder<String, String>()
-                .put("thrift.client.transport", "HEADER")
+                .put("thrift.client.transport", "FRAMED")
                 .put("thrift.client.protocol", "COMPACT")
                 .put("thrift.client.connect-timeout", "99ms")
                 .put("thrift.client.request-timeout", "33m")
@@ -91,7 +91,8 @@ public void testExplicitPropertyMappings()
                 .build();
 
         DriftNettyClientConfig expected = new DriftNettyClientConfig()
-                .setTransport(HEADER)
+                // testing a Transport that is not the default (HEADER)
+                .setTransport(FRAMED)
                 .setProtocol(COMPACT)
                 .setConnectTimeout(new Duration(99, MILLISECONDS))
                 .setRequestTimeout(new Duration(33, MINUTES))

drift-transport-netty/src/test/java/com/facebook/drift/transport/netty/client/TestDriftNettyMethodInvoker.java

@@ -372,6 +372,8 @@ public void testTimeout()
     private static int logNiftyInvocationHandlerOptional(HostAndPort address, List<DriftLogEntry> entries)
     {
         DriftNettyClientConfig config = new DriftNettyClientConfig();
+        config.setTransport(FRAMED);
+
         try (TestingPooledByteBufAllocator testingAllocator = new TestingPooledByteBufAllocator();
                 DriftNettyMethodInvokerFactory<Void> methodInvokerFactory = new DriftNettyMethodInvokerFactory<>(
                         new DriftNettyConnectionFactoryConfig(),