-
Notifications
You must be signed in to change notification settings - Fork 1.6k
Open
Labels
Status: Needs TriageIssue will be reviewed by Core Team and a relevant label will be added as soon as possibleIssue will be reviewed by Core Team and a relevant label will be added as soon as possible
Description
Describe the bug
PrimeVue cannot handle the DatePicker increment/decrement button unless the specific date is selected.
Pull Request Link
No response
Reason for not contributing a PR
- Lack of time
- Unsure how to implement the fix/feature
- Difficulty understanding the codebase
- Other
Other Reason
No response
Reproducer
https://stackblitz.com/edit/rt9udosq?file=src%2FApp.vue
Environment
Default environment.
It happens on all platforms.
Vue version
^3.2.45
PrimeVue version
4.4.1
Node version
No response
Browser(s)
No response
Steps to reproduce the behavior
- Open the DatePicker popup window.
- Just click on the time increment button.
- Errors in console.
chunk-WRYKAXUK.js?v=ddcff751:2167 [Vue warn]: Unhandled error during execution of native event handler
at <Button class="p-datepicker-increment-button" aria-label="Next Hour" unstyled=undefined ... >
at <BaseTransition onEnter=fn onAfterEnter=fn<bound onOverlayEnterComplete> onAfterLeave=fn<bound onOverlayAfterLeave> ... >
at <Transition name="p-connected-overlay" onEnter=fn onAfterEnter=fn<bound onOverlayEnterComplete> ... >
at <Portal appendTo="body" disabled=false >
at <DatePicker showTime="" modelValue=undefined onUpdate:modelValue=fn ... >
at <App>
warn$1 @ chunk-WRYKAXUK.js?v=ddcff751:2167
logError @ chunk-WRYKAXUK.js?v=ddcff751:2379
handleError @ chunk-WRYKAXUK.js?v=ddcff751:2371
callWithErrorHandling @ chunk-WRYKAXUK.js?v=ddcff751:2317
callWithAsyncErrorHandling @ chunk-WRYKAXUK.js?v=ddcff751:2322
invoker @ chunk-WRYKAXUK.js?v=ddcff751:11408
chunk-WRYKAXUK.js?v=ddcff751:2384 Uncaught TypeError: Cannot read properties of undefined (reading '1')
at Proxy.validateTime (primevue_datepicker.js?v=ae00d42f:3425:30)
at Proxy.incrementHour (primevue_datepicker.js?v=ae00d42f:3475:16)
at Proxy.repeat (primevue_datepicker.js?v=ae00d42f:3393:18)
at Proxy.onTimePickerElementMouseDown (primevue_datepicker.js?v=ae00d42f:3344:14)
at mergeProps.onMousedown._cache.<computed>._cache.<computed> (primevue_datepicker.js?v=ae00d42f:5478:33)
at callWithErrorHandling (chunk-WRYKAXUK.js?v=ddcff751:2315:19)
at callWithAsyncErrorHandling (chunk-WRYKAXUK.js?v=ddcff751:2322:17)
at HTMLButtonElement.invoker (chunk-WRYKAXUK.js?v=ddcff751:11408:5)
validateTime @ primevue_datepicker.js?v=ae00d42f:3425
incrementHour @ primevue_datepicker.js?v=ae00d42f:3475
repeat @ primevue_datepicker.js?v=ae00d42f:3393
onTimePickerElementMouseDown @ primevue_datepicker.js?v=ae00d42f:3344
mergeProps.onMousedown._cache.<computed>._cache.<computed> @ primevue_datepicker.js?v=ae00d42f:5478
callWithErrorHandling @ chunk-WRYKAXUK.js?v=ddcff751:2315
callWithAsyncErrorHandling @ chunk-WRYKAXUK.js?v=ddcff751:2322
invoker @ chunk-WRYKAXUK.js?v=ddcff751:11408
chunk-WRYKAXUK.js?v=ddcff751:2167 [Vue warn]: Unhandled error during execution of native event handler
at <Button class="p-datepicker-increment-button" aria-label="Next Hour" unstyled=undefined ... >
at <BaseTransition onEnter=fn onAfterEnter=fn<bound onOverlayEnterComplete> onAfterLeave=fn<bound onOverlayAfterLeave> ... >
at <Transition name="p-connected-overlay" onEnter=fn onAfterEnter=fn<bound onOverlayEnterComplete> ... >
at <Portal appendTo="body" disabled=false >
at <DatePicker showTime="" modelValue=undefined onUpdate:modelValue=fn ... >
at <App>
warn$1 @ chunk-WRYKAXUK.js?v=ddcff751:2167
logError @ chunk-WRYKAXUK.js?v=ddcff751:2379
handleError @ chunk-WRYKAXUK.js?v=ddcff751:2371
callWithErrorHandling @ chunk-WRYKAXUK.js?v=ddcff751:2317
callWithAsyncErrorHandling @ chunk-WRYKAXUK.js?v=ddcff751:2322
invoker @ chunk-WRYKAXUK.js?v=ddcff751:11408
chunk-WRYKAXUK.js?v=ddcff751:2384 Uncaught TypeError: Cannot read properties of undefined (reading '0')
at Proxy.updateModelTime (primevue_datepicker.js?v=ae00d42f:3533:30)
at Proxy.onTimePickerElementMouseUp (primevue_datepicker.js?v=ae00d42f:3351:14)
at mergeProps.onMouseup._cache.<computed>._cache.<computed> (primevue_datepicker.js?v=ae00d42f:5481:33)
at callWithErrorHandling (chunk-WRYKAXUK.js?v=ddcff751:2315:19)
at callWithAsyncErrorHandling (chunk-WRYKAXUK.js?v=ddcff751:2322:17)
at HTMLButtonElement.invoker (chunk-WRYKAXUK.js?v=ddcff751:11408:5)
updateModelTime @ primevue_datepicker.js?v=ae00d42f:3533
onTimePickerElementMouseUp @ primevue_datepicker.js?v=ae00d42f:3351
mergeProps.onMouseup._cache.<computed>._cache.<computed> @ primevue_datepicker.js?v=ae00d42f:5481
callWithErrorHandling @ chunk-WRYKAXUK.js?v=ddcff751:2315
callWithAsyncErrorHandling @ chunk-WRYKAXUK.js?v=ddcff751:2322
invoker @ chunk-WRYKAXUK.js?v=ddcff751:11408
chunk-WRYKAXUK.js?v=ddcff751:2167 [Vue warn]: Unhandled error during execution of native event handler
at <Button class="p-datepicker-increment-button" aria-label="Next Hour" unstyled=undefined ... >
at <BaseTransition onEnter=fn onAfterEnter=fn<bound onOverlayEnterComplete> onAfterLeave=fn<bound onOverlayAfterLeave> ... >
at <Transition name="p-connected-overlay" onEnter=fn onAfterEnter=fn<bound onOverlayEnterComplete> ... >
at <Portal appendTo="body" disabled=false >
at <DatePicker showTime="" modelValue=undefined onUpdate:modelValue=fn ... >
at <App>
warn$1 @ chunk-WRYKAXUK.js?v=ddcff751:2167
logError @ chunk-WRYKAXUK.js?v=ddcff751:2379
handleError @ chunk-WRYKAXUK.js?v=ddcff751:2371
callWithErrorHandling @ chunk-WRYKAXUK.js?v=ddcff751:2317
callWithAsyncErrorHandling @ chunk-WRYKAXUK.js?v=ddcff751:2322
invoker @ chunk-WRYKAXUK.js?v=ddcff751:11408
chunk-WRYKAXUK.js?v=ddcff751:2384 Uncaught TypeError: Cannot read properties of undefined (reading '1')
at Proxy.validateTime (primevue_datepicker.js?v=ae00d42f:3425:30)
at Proxy.incrementHour (primevue_datepicker.js?v=ae00d42f:3475:16)
at Proxy.repeat (primevue_datepicker.js?v=ae00d42f:3393:18)
at Proxy.onTimePickerElementMouseDown (primevue_datepicker.js?v=ae00d42f:3344:14)
at mergeProps.onMousedown._cache.<computed>._cache.<computed> (primevue_datepicker.js?v=ae00d42f:5478:33)
at callWithErrorHandling (chunk-WRYKAXUK.js?v=ddcff751:2315:19)
at callWithAsyncErrorHandling (chunk-WRYKAXUK.js?v=ddcff751:2322:17)
at HTMLButtonElement.invoker (chunk-WRYKAXUK.js?v=ddcff751:11408:5)
validateTime @ primevue_datepicker.js?v=ae00d42f:3425
incrementHour @ primevue_datepicker.js?v=ae00d42f:3475
repeat @ primevue_datepicker.js?v=ae00d42f:3393
onTimePickerElementMouseDown @ primevue_datepicker.js?v=ae00d42f:3344
mergeProps.onMousedown._cache.<computed>._cache.<computed> @ primevue_datepicker.js?v=ae00d42f:5478
callWithErrorHandling @ chunk-WRYKAXUK.js?v=ddcff751:2315
callWithAsyncErrorHandling @ chunk-WRYKAXUK.js?v=ddcff751:2322
invoker @ chunk-WRYKAXUK.js?v=ddcff751:11408
chunk-WRYKAXUK.js?v=ddcff751:2167 [Vue warn]: Unhandled error during execution of native event handler
at <Button class="p-datepicker-increment-button" aria-label="Next Hour" unstyled=undefined ... >
at <BaseTransition onEnter=fn onAfterEnter=fn<bound onOverlayEnterComplete> onAfterLeave=fn<bound onOverlayAfterLeave> ... >
at <Transition name="p-connected-overlay" onEnter=fn onAfterEnter=fn<bound onOverlayEnterComplete> ... >
at <Portal appendTo="body" disabled=false >
at <DatePicker showTime="" modelValue=undefined onUpdate:modelValue=fn ... >
at <App>
warn$1 @ chunk-WRYKAXUK.js?v=ddcff751:2167
logError @ chunk-WRYKAXUK.js?v=ddcff751:2379
handleError @ chunk-WRYKAXUK.js?v=ddcff751:2371
callWithErrorHandling @ chunk-WRYKAXUK.js?v=ddcff751:2317
callWithAsyncErrorHandling @ chunk-WRYKAXUK.js?v=ddcff751:2322
invoker @ chunk-WRYKAXUK.js?v=ddcff751:11408
chunk-WRYKAXUK.js?v=ddcff751:2384 Uncaught TypeError: Cannot read properties of undefined (reading '0')
at Proxy.updateModelTime (primevue_datepicker.js?v=ae00d42f:3533:30)
at Proxy.onTimePickerElementMouseUp (primevue_datepicker.js?v=ae00d42f:3351:14)
at mergeProps.onMouseup._cache.<computed>._cache.<computed> (primevue_datepicker.js?v=ae00d42f:5481:33)
at callWithErrorHandling (chunk-WRYKAXUK.js?v=ddcff751:2315:19)
at callWithAsyncErrorHandling (chunk-WRYKAXUK.js?v=ddcff751:2322:17)
at HTMLButtonElement.invoker (chunk-WRYKAXUK.js?v=ddcff751:11408:5)
updateModelTime @ primevue_datepicker.js?v=ae00d42f:3533
onTimePickerElementMouseUp @ primevue_datepicker.js?v=ae00d42f:3351
mergeProps.onMouseup._cache.<computed>._cache.<computed> @ primevue_datepicker.js?v=ae00d42f:5481
callWithErrorHandling @ chunk-WRYKAXUK.js?v=ddcff751:2315
callWithAsyncErrorHandling @ chunk-WRYKAXUK.js?v=ddcff751:2322
invoker @ chunk-WRYKAXUK.js?v=ddcff751:11408
Expected behavior
- No errors are shown, and the time can be decreased/increased.
- Probably just hide the time selection area before the date is selected.
Metadata
Metadata
Assignees
Labels
Status: Needs TriageIssue will be reviewed by Core Team and a relevant label will be added as soon as possibleIssue will be reviewed by Core Team and a relevant label will be added as soon as possible