Skip to content

Invalid value for symbolicon.constant in dark theme variants. #409

@DavidSeptimus

Description

@DavidSeptimus

Description

Most of the dark variants include an array of colors for symbolicon.constant when the schema expects a string. VS Code ignores the invalid value (the constant icon displays as white), but other libraries/tools may fail to parse the theme because of that value.

Image

(see shikijs/shiki#894).

Steps to reproduce

  1. Enable one of the affected dark variants in VS Code.
  2. Open a new python document and enter the following:
MY_CONST = "val"
  1. Open the command palette and activate Explorer: Focus on Outline View
  2. Check the outline view in the bottom-left corner and you'll see that MY_CONST's icon is white because the array of green colors associated with symbolicon.constant in the theme is an invalid value.

Version

v6.3.5

Theme

GitHub Dark High Contrast, GitHub Dark Default, GitHub Dark Colorblind, GitHub Dark Dimmed, GitHub Dark

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions