Add back aria-haspopup="true"

Author: TylerJDev

packages/react/src/ActionMenu/ActionMenu.tsx

@@ -315,7 +315,6 @@ const Overlay: FCWithSlotMarker<React.PropsWithChildren<MenuOverlayProps>> = ({
       focusZoneSettings={isNarrowFullscreen ? {disabled: true} : {focusOutBehavior: 'wrap'}}
       onPositionChange={onPositionChange}
       variant={variant}
-      aria-haspopup="menu"
     >
       <div
         ref={containerRef}

packages/react/src/AnchoredOverlay/AnchoredOverlay.tsx

@@ -117,11 +117,6 @@ interface AnchoredOverlayBaseProps extends Pick<OverlayProps, 'height' | 'width'
    * Props to be spread on the close button in the overlay.
    */
   closeButtonProps?: Partial<IconButtonProps>
-
-  /**
-   * ARIA property indicating the availability and type of interactive popup element
-   */
-  'aria-haspopup'?: boolean | 'dialog' | 'menu' | 'grid' | 'listbox' | 'tree' | 'true' | 'false'
 }
 
 export type AnchoredOverlayProps = AnchoredOverlayBaseProps &
@@ -156,7 +151,6 @@ export const AnchoredOverlay: React.FC<React.PropsWithChildren<AnchoredOverlayPr
   align = 'start',
   alignmentOffset,
   anchorOffset,
-  'aria-haspopup': _ariaHaspopup,
   className,
   pinPosition,
   variant = defaultVariant,
@@ -243,7 +237,7 @@ export const AnchoredOverlay: React.FC<React.PropsWithChildren<AnchoredOverlayPr
         renderAnchor({
           ref: anchorRef,
           id: anchorId,
-          'aria-haspopup': _ariaHaspopup || 'true',
+          'aria-haspopup': 'true',
           'aria-expanded': open,
           tabIndex: 0,
           onClick: onAnchorClick,

packages/react/src/Button/IconButton.tsx

@@ -34,7 +34,7 @@ const IconButton = forwardRef(
 
     // If the button has an active "popup" (like a menu), we don't want to show the tooltip.
     // This is mostly for `ActionMenu`, but could be applicable elsewhere.
-    const hasActivePopup = isExpanded && hasPopup === 'menu'
+    const hasActivePopup = isExpanded && hasPopup === 'true'
 
     const withoutTooltip =
       unsafeDisableTooltip ||