From e1205b96a7050d00a86aa6dea7654624c646b858 Mon Sep 17 00:00:00 2001 From: Josh Black Date: Mon, 7 Jul 2025 11:41:19 -0500 Subject: [PATCH 1/4] Update UnderlinePanels.tsx --- .../src/experimental/UnderlinePanels/UnderlinePanels.tsx | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/packages/react/src/experimental/UnderlinePanels/UnderlinePanels.tsx b/packages/react/src/experimental/UnderlinePanels/UnderlinePanels.tsx index 94ec2df6142..7cc28498828 100644 --- a/packages/react/src/experimental/UnderlinePanels/UnderlinePanels.tsx +++ b/packages/react/src/experimental/UnderlinePanels/UnderlinePanels.tsx @@ -171,13 +171,13 @@ const UnderlinePanels: FC = ({ } return ( - + From bcf904c6343c5ba19e57b8fc0a7f38c602f3232a Mon Sep 17 00:00:00 2001 From: Mike Perrotti Date: Thu, 10 Jul 2025 18:06:05 -0400 Subject: [PATCH 2/4] fixes bad merge --- .../react/src/experimental/UnderlinePanels/UnderlinePanels.tsx | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/packages/react/src/experimental/UnderlinePanels/UnderlinePanels.tsx b/packages/react/src/experimental/UnderlinePanels/UnderlinePanels.tsx index a72c4c263e1..9290755a8f0 100644 --- a/packages/react/src/experimental/UnderlinePanels/UnderlinePanels.tsx +++ b/packages/react/src/experimental/UnderlinePanels/UnderlinePanels.tsx @@ -24,7 +24,6 @@ import {type SxProp} from '../../sx' import {useResizeObserver, type ResizeObserverEntry} from '../../hooks/useResizeObserver' import useIsomorphicLayoutEffect from '../../utils/useIsomorphicLayoutEffect' import classes from './UnderlinePanels.module.css' -import {clsx} from 'clsx' import {BoxWithFallback} from '../../internal/components/BoxWithFallback' export type UnderlinePanelsProps = { @@ -175,7 +174,7 @@ const UnderlinePanels: FC = ({ ref={wrapperRef} slot="tablist-wrapper" data-icons-visible={iconsVisible} - className={clsx(className, classes.StyledUnderlineWrapper)} + className={classes.StyledUnderlineWrapper} {...props} > From b672bd115bb01fd2494c4db8ae10353dad8d895e Mon Sep 17 00:00:00 2001 From: Mike Perrotti Date: Thu, 10 Jul 2025 18:24:22 -0400 Subject: [PATCH 3/4] updates prop docs and tests --- .../experimental/UnderlinePanels/UnderlinePanels.docs.json | 7 +++++++ .../experimental/UnderlinePanels/UnderlinePanels.test.tsx | 2 +- .../src/experimental/UnderlinePanels/UnderlinePanels.tsx | 2 +- 3 files changed, 9 insertions(+), 2 deletions(-) diff --git a/packages/react/src/experimental/UnderlinePanels/UnderlinePanels.docs.json b/packages/react/src/experimental/UnderlinePanels/UnderlinePanels.docs.json index f2ccc0d554b..5195e4a29bd 100644 --- a/packages/react/src/experimental/UnderlinePanels/UnderlinePanels.docs.json +++ b/packages/react/src/experimental/UnderlinePanels/UnderlinePanels.docs.json @@ -47,6 +47,13 @@ "required": true, "description": "Tabs (UnderlinePanels.Tab) and panels (UnderlinePanels.Panel) to render" }, + { + "name": "className", + "type": "string", + "required": false, + "description": "Custom className. Is applied to the custom element, [tab-container](https://github.com/github/tab-container-element)", + "defaultValue": "" + }, { "name": "id", "type": "string", diff --git a/packages/react/src/experimental/UnderlinePanels/UnderlinePanels.test.tsx b/packages/react/src/experimental/UnderlinePanels/UnderlinePanels.test.tsx index ffbc185d9b1..58f9e2daa28 100644 --- a/packages/react/src/experimental/UnderlinePanels/UnderlinePanels.test.tsx +++ b/packages/react/src/experimental/UnderlinePanels/UnderlinePanels.test.tsx @@ -161,6 +161,6 @@ describe('UnderlinePanels', () => { Panel 2 ) - expect(render().baseElement.firstChild?.firstChild?.firstChild).toHaveClass('test-class-name') + expect(render().baseElement.firstChild?.firstChild).toHaveClass('test-class-name') }) }) diff --git a/packages/react/src/experimental/UnderlinePanels/UnderlinePanels.tsx b/packages/react/src/experimental/UnderlinePanels/UnderlinePanels.tsx index 9290755a8f0..242dad23f57 100644 --- a/packages/react/src/experimental/UnderlinePanels/UnderlinePanels.tsx +++ b/packages/react/src/experimental/UnderlinePanels/UnderlinePanels.tsx @@ -48,7 +48,7 @@ export type UnderlinePanelsProps = { */ loadingCounters?: boolean /** - * Class name for custom styling + * Class name for custom styling. Is applied to the custom element, [tab-container](https://github.com/github/tab-container-element) */ className?: string } & SxProp From a65e1612eb981c13e10987b141bb24a7f2924746 Mon Sep 17 00:00:00 2001 From: Mike Perrotti Date: Thu, 10 Jul 2025 18:51:35 -0400 Subject: [PATCH 4/4] forgot to save docs.json before committing --- .../src/experimental/UnderlinePanels/UnderlinePanels.docs.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/react/src/experimental/UnderlinePanels/UnderlinePanels.docs.json b/packages/react/src/experimental/UnderlinePanels/UnderlinePanels.docs.json index 5195e4a29bd..8804541cd09 100644 --- a/packages/react/src/experimental/UnderlinePanels/UnderlinePanels.docs.json +++ b/packages/react/src/experimental/UnderlinePanels/UnderlinePanels.docs.json @@ -51,7 +51,7 @@ "name": "className", "type": "string", "required": false, - "description": "Custom className. Is applied to the custom element, [tab-container](https://github.com/github/tab-container-element)", + "description": "Class name for custom styling. Is applied to the custom element, [tab-container](https://github.com/github/tab-container-element)", "defaultValue": "" }, {