Skip to content

Commit c829971

Browse files
test against ruby 3.4 in CI (#3598)
Co-authored-by: Jon Rohan <rohan@github.com>
1 parent 25a2a68 commit c829971

File tree

2 files changed

+9
-9
lines changed

2 files changed

+9
-9
lines changed

.github/workflows/test.yml

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@ jobs:
3030
- uses: actions/checkout@v4
3131
- uses: ruby/setup-ruby@v1
3232
with:
33-
ruby-version: '3.3'
33+
ruby-version: '3.4'
3434
bundler-cache: true
3535
- uses: actions/setup-node@v4
3636
with:
@@ -56,10 +56,10 @@ jobs:
5656
ruby_version: "3.2"
5757
- rails_version: "7.1.3"
5858
ruby_version: "3.3"
59-
- rails_version: "main"
60-
ruby_version: "3.2"
6159
- rails_version: "main"
6260
ruby_version: "3.3"
61+
- rails_version: "main"
62+
ruby_version: "3.4"
6363
steps:
6464
- uses: actions/checkout@v4
6565
- uses: ruby/setup-ruby@v1
@@ -98,10 +98,10 @@ jobs:
9898
ruby_version: "3.2"
9999
- rails_version: "7.1.3"
100100
ruby_version: "3.3"
101-
- rails_version: "main"
102-
ruby_version: "3.2"
103101
- rails_version: "main"
104102
ruby_version: "3.3"
103+
- rails_version: "main"
104+
ruby_version: "3.4"
105105
steps:
106106
- uses: actions/checkout@v4
107107
- uses: ruby/setup-ruby@v1
@@ -140,10 +140,10 @@ jobs:
140140
ruby_version: "3.2"
141141
- rails_version: "7.1.3"
142142
ruby_version: "3.3"
143-
- rails_version: "main"
144-
ruby_version: "3.2"
145143
- rails_version: "main"
146144
ruby_version: "3.3"
145+
- rails_version: "main"
146+
ruby_version: "3.4"
147147
steps:
148148
- uses: actions/checkout@v4
149149
- uses: ruby/setup-ruby@v1

test/performance/bench_octicons.rb

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ def setup
1717
def bench_allocations_without_cache
1818
Primer::Beta::Octicon.new(**@options)
1919
Primer::Octicon::Cache.clear!
20-
assert_allocations "3.4" => 26, "3.3" => 26, "3.2" => 26, "3.1" => 28, "3.0" => 28 do
20+
assert_allocations "3.4" => 25, "3.3" => 26, "3.2" => 26, "3.1" => 28, "3.0" => 28 do
2121
Primer::Beta::Octicon.new(**@options)
2222
end
2323
ensure
@@ -26,7 +26,7 @@ def bench_allocations_without_cache
2626

2727
def bench_allocations_with_cache
2828
Primer::Octicon::Cache.preload!
29-
assert_allocations "3.4" => 10, "3.3" => 10, "3.2" => 10, "3.1" => 11, "3.0" => 11 do
29+
assert_allocations "3.4" => 9, "3.3" => 10, "3.2" => 10, "3.1" => 11, "3.0" => 11 do
3030
Primer::Beta::Octicon.new(**@options)
3131
end
3232
end

0 commit comments

Comments
 (0)