Scope.cloneForTermReference

Author: stasm

fluent/src/resolver.js

@@ -191,9 +191,9 @@ function TermReference(scope, {name, attr, args}) {
     return new FluentNone(id);
   }
 
-  // Every TermReference has its own args.
-  const [, keyargs] = getArguments(scope, args);
-  const local = scope.clone(keyargs);
+  // Every TermReference has its own variables.
+  const [, params] = getArguments(scope, args);
+  const local = scope.cloneForTermReference(params);
 
   if (attr) {
     const attribute = term.attributes[attr];

fluent/src/scope.js

@@ -1,16 +1,22 @@
 export default class Scope {
-  constructor(bundle, errors, args,
-    insideTermReference = false, dirty = new WeakSet()
+  constructor(
+    bundle,
+    errors,
+    args,
+    insideTermReference = false,
+    dirty = new WeakSet()
   ) {
     this.bundle = bundle;
     this.errors = errors;
     this.args = args;
-    this.dirty = dirty;
-    // TermReferences are resolved in a new scope.
+
+    // Term references require different variable lookup logic.
     this.insideTermReference = insideTermReference;
+    // Keeps track of visited Patterns. Used to detect cyclic references.
+    this.dirty = dirty;
   }
 
-  clone(args) {
+  cloneForTermReference(args) {
     return new Scope(this.bundle, this.errors, args, true, this.dirty);
   }