Skip to content

Commit f2d23f3

Browse files
committed
Update dependencies for react example.
Stop saving `@fluent/react` as it has conflicting hashes whenever you build locally. Instead add its runtime dependencies.
1 parent e231525 commit f2d23f3

File tree

3 files changed

+1317
-1760
lines changed

3 files changed

+1317
-1760
lines changed

fluent-react/example/README.md

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,12 +16,16 @@ Then build and package `@fluent/react`:
1616
npm install
1717
make
1818
npm pack
19-
mv fluent-react-*.tgz example/fluent-react.tgz
2019

2120
Finally, change back to this directory, and build the example:
2221

2322
cd fluent.js/fluent-react/example/
2423
npm install
24+
npm install --no-save ../fluent-react-*.tgz
2525
npm start
2626

2727
Open http://localhost:1234 to see the example running.
28+
29+
Installing `@fluent/react` via `npm pack` allows to use the in-tree
30+
version of it without picking up the `devDependencies`, which likely
31+
bring a conflicting version of React.

0 commit comments

Comments
 (0)