-
Notifications
You must be signed in to change notification settings - Fork 46
Closed
Labels
Description
The issue
Currently selected rules do not persist anyhow.
Whenever I reload the page - my progress is lost. If I'd like to share it with someone - I need to send the raw files to that person.
For the sake of this ticket, I'll name them:
- The page-reload issue
- The quick-share issue
Options
I see few options, and I have my personal preference.
Let's go through proposals for storing the currently selected rules state:
- Keep the state in local storage local storage: helps with the (1.) page-reload issue, but has to be managed/cleaned etc. Not solving the (2.) quick-share issue
- Keep the state in any non-local/server-side persistence: just overshoot, not needed to resolve those issues 😛
- Keep the state in URL query params: Compress and encode the state, then put it as a URL query param -
rules=...
. This solves both issues fully client-side, is easy to wipe, and is easy to share.
Proposed solution
I'd go with 3. - keep the state URL query param, and update it on every current selected rules state update 😊
PS I've scanned the code and I see some sketches of introducing user accounts and some data management, but I hope my idea is not in conflict with those plans :)
PPS If you find this idea helpful - I'd be happy to implement it 😊
psmyrdek