2.32.5 breaks passing custom SSL context #7040
Description
2.32.5 change 90fee08 breaks passing of custom ssl context using an adapter like this:
class SSLContextAdapter(requests.adapters.HTTPAdapter):
@override
def init_poolmanager(self, *args: Any, **kwargs: Any) -> Any:
kwargs["ssl_context"] = ssl.create_default_context()
return super().init_poolmanager(*args, **kwargs) # type: ignore
ssl_adapter = SSLContextAdapter()
session.mount("https://", ssl_adapter)Now, if verify=True, the code in
requests/src/requests/adapters.py
Lines 292 to 313 in 90fee08
ca_certs, which causes urllib3 to modify the ssl_context by loading more certs into it here.
EDIT: I can be fixed by overriding also cert_verify:
class SSLContextAdapter(requests.adapters.HTTPAdapter):
@override
def init_poolmanager(self, *args: Any, **kwargs: Any) -> Any:
kwargs["ssl_context"] = ssl.create_default_context()
return super().init_poolmanager(*args, **kwargs) # type: ignore
@override
def cert_verify(self, *_args: Any, **_kwargs: Any) -> None:
pass
ssl_adapter = SSLContextAdapter()
session.mount("https://", ssl_adapter)I'd say this belongs to documentation and needs some tests, so that future changes don't break it again - will prepare a PR if I'll have time.