Skip to content

Fix/prevent retry for non retryable 404 status code #488

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
mohitpubnub merged 10 commits into from
Jan 13, 2026
Merged

Fix/prevent retry for non retryable 404 status code #488

mohitpubnub merged 10 commits into from
Jan 13, 2026

Conversation

@mohitpubnub
Copy link
Contributor

@mohitpubnub mohitpubnub commented Jan 12, 2026 •
edited
Loading

refactor: prevent retry on http status code 404.

Prevent retry when response is having http status code 404.

@mohitpubnub mohitpubnub requested a review from parfeon as a code owner January 12, 2026 14:04
@pubnub-ops-terraform
Copy link

pubnub-ops-terraform commented Jan 12, 2026 •
edited
Loading

✅ Snyk checks have passed. No issues have been found so far.

Status Scanner Critical High Medium Low Total (0)
✅ Open Source Security 0 0 0 0 0 issues
✅ Licenses 0 0 0 0 0 issues

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

@mohitpubnub mohitpubnub self-assigned this Jan 12, 2026
@mohitpubnub mohitpubnub added status: done This issue is considered resolved. priority: medium This PR should be reviewed after all high priority PRs. labels Jan 12, 2026
@mohitpubnub mohitpubnub changed the title Fix/prevent retry non retryable Fix/prevent retry for non retryable 404 status code Jan 12, 2026
parfeon
parfeon approved these changes Jan 13, 2026
View reviewed changes
Copy link
Contributor

@parfeon parfeon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mohitpubnub
Copy link
Contributor Author

mohitpubnub commented Jan 13, 2026

@pubnub-release-bot release

@mohitpubnub mohitpubnub merged commit 32cc0bd into master Jan 13, 2026
9 checks passed
@mohitpubnub mohitpubnub deleted the fix/prevent-retry-nonRetryable branch January 13, 2026 09:53
@pubnub-release-bot
Copy link
Contributor

pubnub-release-bot commented Jan 13, 2026

🚀 Release successfully completed 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@parfeon parfeon parfeon approved these changes

@techwritermat techwritermat Awaiting requested review from techwritermat techwritermat is a code owner

@kazydek kazydek Awaiting requested review from kazydek kazydek is a code owner

Assignees

@mohitpubnub mohitpubnub

Labels

priority: medium This PR should be reviewed after all high priority PRs. status: done This issue is considered resolved.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@mohitpubnub @pubnub-ops-terraform @pubnub-release-bot @parfeon