Make dot helper handle magic method #10

Author: kylekatarnls

phpunit.xml

@@ -22,6 +22,9 @@
         <testsuite name="options">
             <file>tests/options.php</file>
         </testsuite>
+        <testsuite name="helpers">
+            <file>tests/dotHelper.php</file>
+        </testsuite>
         <testsuite name="badSyntaxes">
             <file>tests/badSyntaxes.php</file>
             <file>tests/badSwitchSyntaxes.php</file>

src/JsPhpize/Compiler/Helpers/Dot.h

@@ -1,19 +1,27 @@
 function ($base) {
+    $getCallable = function ($base, $key) {
+        if (is_callable(array($base, $key))) {
+            return array($base, $key);
+        }
+    };
     foreach (array_slice(func_get_args(), 1) as $key) {
         $base = is_array($base)
-            ? (isset($base[$key]) ? $base[$key] : null)
+            ? (isset($base[$key])
+                ? $base[$key]
+                : null
+             )
             : (is_object($base)
                 ? (isset($base->$key)
                     ? $base->$key
                     : (method_exists($base, $method = "get" . ucfirst($key))
                         ? $base->$method()
                         : (method_exists($base, $key)
                             ? array($base, $key)
-                            : null
+                            : $getCallable($base, $key)
                         )
                     )
                 )
-                : null
+                : $getCallable($base, $key)
             );
     }
 

tests/dotHelper.php

@@ -0,0 +1,117 @@
+<?php
+
+use JsPhpize\JsPhpize;
+
+class MagicMethodObject
+{
+    public function __get($name)
+    {
+        if ($name === 'foo') {
+            return 'bar';
+        }
+    }
+
+    public function __call($name, array $args)
+    {
+        if ($name === 'bar') {
+            return 'biz';
+        }
+    }
+
+    public function __isset($name)
+    {
+        return $name === 'foo';
+    }
+}
+
+class DotHelperTest extends \PHPUnit_Framework_TestCase
+{
+    protected function getDotHelper()
+    {
+        return eval('return ' . file_get_contents(__DIR__ . '/../src/JsPhpize/Compiler/Helpers/Dot.h') . ';');
+    }
+
+    public function testArrayValue()
+    {
+        $dotHelper = $this->getDotHelper();
+
+        $this->assertSame(42, $dotHelper(array(
+                'foo' => 42,
+            ), 'foo'));
+        $this->assertSame('biz', $dotHelper(array(
+                'foo' => array(
+                    'bar' => 'biz',
+                ),
+            ), 'foo', 'bar'));
+        $this->assertSame(null, $dotHelper(array(
+                'foo' => array(
+                ),
+            ), 'foo', 'bar'));
+        $this->assertSame(null, $dotHelper(array(
+                'foo' => array(
+                ),
+            ), 'biz', 'bar'));
+    }
+
+    public function testObjectMember()
+    {
+        $dotHelper = $this->getDotHelper();
+
+        $this->assertSame(42, $dotHelper((object) array(
+                'foo' => 42,
+            ), 'foo'));
+        $this->assertSame('biz', $dotHelper((object) array(
+                'foo' => (object) array(
+                    'bar' => 'biz',
+                ),
+            ), 'foo', 'bar'));
+        $this->assertSame(null, $dotHelper((object) array(
+                'foo' => (object) array(
+                ),
+            ), 'foo', 'bar'));
+        $this->assertSame(null, $dotHelper((object) array(
+                'foo' => (object) array(
+                ),
+            ), 'biz', 'bar'));
+    }
+
+    public function testMixedObjectMemberAndArayValue()
+    {
+        $dotHelper = $this->getDotHelper();
+
+        $this->assertSame('biz', $dotHelper(array(
+                'foo' => (object) array(
+                    'bar' => 'biz',
+                ),
+            ), 'foo', 'bar'));
+        $this->assertSame('biz', $dotHelper((object) array(
+                'foo' => array(
+                    'bar' => 'biz',
+                ),
+            ), 'foo', 'bar'));
+        $this->assertSame(42, $dotHelper((object) array(
+                'foo' => array(
+                    'bar' => (object) array(
+                        'biz' => 42,
+                    ),
+                ),
+            ), 'foo', 'bar', 'biz'));
+        $this->assertSame(42, $dotHelper(array(
+                'foo' => (object) array(
+                    'bar' => array(
+                        'biz' => 42,
+                    ),
+                ),
+            ), 'foo', 'bar', 'biz'));
+    }
+
+    public function testMagicMethod()
+    {
+        $dotHelper = $this->getDotHelper();
+        $object = new MagicMethodObject();
+
+        $this->assertSame('bar', $dotHelper($object, 'foo'));
+        $this->assertSame('biz', call_user_func($dotHelper($object, 'bar')));
+        $this->assertSame(null, call_user_func($dotHelper($object, 'biz')));
+    }
+}