Ignore golangci-lint migrate errors (#1763)

blampe · web-flow · commit bbd20b684dd2 · 2025-10-01T23:00:04.000Z
Some providers don't have golangci-lint configured at all, and we don't want migrations to fail in those cases. This changes the config migration to best-effort. Fixes #1754.
diff --git a/provider-ci/internal/pkg/migrations/maintain_golangci_config.go b/provider-ci/internal/pkg/migrations/maintain_golangci_config.go
@@ -65,8 +65,8 @@ func (maintainGolangciConfig) Migrate(_ string, cwd string) error {
 	output, err := cmd.CombinedOutput()
 
 	if err != nil {
-		fmt.Println(string(output))
-		return fmt.Errorf("problem migrating golangci-lint config: %w", err)
+		fmt.Printf("Problem migrating golangci-lint config:\n%s\n%s\n", err, string(output))
+		return nil
 	}
 
 	// Cleanup the backup config if all went well.
diff --git a/provider-ci/internal/pkg/templates/internal/.github/workflows/comment-on-stale-issues.yml b/provider-ci/internal/pkg/templates/internal/.github/workflows/comment-on-stale-issues.yml
@@ -9,7 +9,7 @@ jobs:
     runs-on: ubuntu-latest
     name: Stale issue job
     steps:
-    - uses: aws-actions/stale-issue-cleanup@5650b49bcd757a078f6ca06c373d7807b773f9bc #v7.1.0
+    - uses: aws-actions/stale-issue-cleanup@db44981197ae9cdada9a9c779c052439f9d62eac #v7.1.0
       with:
         issue-types: issues # only look at issues (ignore pull-requests)
 
diff --git a/provider-ci/test-providers/aws-native/.github/workflows/comment-on-stale-issues.yml b/provider-ci/test-providers/aws-native/.github/workflows/comment-on-stale-issues.yml
@@ -9,7 +9,7 @@ jobs:
     runs-on: ubuntu-latest
     name: Stale issue job
     steps:
-    - uses: aws-actions/stale-issue-cleanup@5650b49bcd757a078f6ca06c373d7807b773f9bc #v7.1.0
+    - uses: aws-actions/stale-issue-cleanup@db44981197ae9cdada9a9c779c052439f9d62eac #v7.1.0
       with:
         issue-types: issues # only look at issues (ignore pull-requests)
 
diff --git a/provider-ci/test-providers/aws/.github/workflows/comment-on-stale-issues.yml b/provider-ci/test-providers/aws/.github/workflows/comment-on-stale-issues.yml
@@ -9,7 +9,7 @@ jobs:
     runs-on: ubuntu-latest
     name: Stale issue job
     steps:
-    - uses: aws-actions/stale-issue-cleanup@5650b49bcd757a078f6ca06c373d7807b773f9bc #v7.1.0
+    - uses: aws-actions/stale-issue-cleanup@db44981197ae9cdada9a9c779c052439f9d62eac #v7.1.0
       with:
         issue-types: issues # only look at issues (ignore pull-requests)
 
diff --git a/provider-ci/test-providers/cloudflare/.github/workflows/comment-on-stale-issues.yml b/provider-ci/test-providers/cloudflare/.github/workflows/comment-on-stale-issues.yml
@@ -9,7 +9,7 @@ jobs:
     runs-on: ubuntu-latest
     name: Stale issue job
     steps:
-    - uses: aws-actions/stale-issue-cleanup@5650b49bcd757a078f6ca06c373d7807b773f9bc #v7.1.0
+    - uses: aws-actions/stale-issue-cleanup@db44981197ae9cdada9a9c779c052439f9d62eac #v7.1.0
       with:
         issue-types: issues # only look at issues (ignore pull-requests)
 
diff --git a/provider-ci/test-providers/command/.github/workflows/comment-on-stale-issues.yml b/provider-ci/test-providers/command/.github/workflows/comment-on-stale-issues.yml
@@ -9,7 +9,7 @@ jobs:
     runs-on: ubuntu-latest
     name: Stale issue job
     steps:
-    - uses: aws-actions/stale-issue-cleanup@5650b49bcd757a078f6ca06c373d7807b773f9bc #v7.1.0
+    - uses: aws-actions/stale-issue-cleanup@db44981197ae9cdada9a9c779c052439f9d62eac #v7.1.0
       with:
         issue-types: issues # only look at issues (ignore pull-requests)
 
diff --git a/provider-ci/test-providers/docker-build/.github/workflows/comment-on-stale-issues.yml b/provider-ci/test-providers/docker-build/.github/workflows/comment-on-stale-issues.yml
@@ -9,7 +9,7 @@ jobs:
     runs-on: ubuntu-latest
     name: Stale issue job
     steps:
-    - uses: aws-actions/stale-issue-cleanup@5650b49bcd757a078f6ca06c373d7807b773f9bc #v7.1.0
+    - uses: aws-actions/stale-issue-cleanup@db44981197ae9cdada9a9c779c052439f9d62eac #v7.1.0
       with:
         issue-types: issues # only look at issues (ignore pull-requests)
 
diff --git a/provider-ci/test-providers/docker/.github/workflows/comment-on-stale-issues.yml b/provider-ci/test-providers/docker/.github/workflows/comment-on-stale-issues.yml
@@ -9,7 +9,7 @@ jobs:
     runs-on: ubuntu-latest
     name: Stale issue job
     steps:
-    - uses: aws-actions/stale-issue-cleanup@5650b49bcd757a078f6ca06c373d7807b773f9bc #v7.1.0
+    - uses: aws-actions/stale-issue-cleanup@db44981197ae9cdada9a9c779c052439f9d62eac #v7.1.0
       with:
         issue-types: issues # only look at issues (ignore pull-requests)
 
diff --git a/provider-ci/test-providers/eks/.github/workflows/comment-on-stale-issues.yml b/provider-ci/test-providers/eks/.github/workflows/comment-on-stale-issues.yml
@@ -9,7 +9,7 @@ jobs:
     runs-on: ubuntu-latest
     name: Stale issue job
     steps:
-    - uses: aws-actions/stale-issue-cleanup@5650b49bcd757a078f6ca06c373d7807b773f9bc #v7.1.0
+    - uses: aws-actions/stale-issue-cleanup@db44981197ae9cdada9a9c779c052439f9d62eac #v7.1.0
       with:
         issue-types: issues # only look at issues (ignore pull-requests)
 
diff --git a/provider-ci/test-providers/kubernetes-cert-manager/.github/workflows/comment-on-stale-issues.yml b/provider-ci/test-providers/kubernetes-cert-manager/.github/workflows/comment-on-stale-issues.yml
@@ -9,7 +9,7 @@ jobs:
     runs-on: ubuntu-latest
     name: Stale issue job
     steps:
-    - uses: aws-actions/stale-issue-cleanup@5650b49bcd757a078f6ca06c373d7807b773f9bc #v7.1.0
+    - uses: aws-actions/stale-issue-cleanup@db44981197ae9cdada9a9c779c052439f9d62eac #v7.1.0
       with:
         issue-types: issues # only look at issues (ignore pull-requests)
 
diff --git a/provider-ci/test-providers/kubernetes-coredns/.github/workflows/comment-on-stale-issues.yml b/provider-ci/test-providers/kubernetes-coredns/.github/workflows/comment-on-stale-issues.yml
@@ -9,7 +9,7 @@ jobs:
     runs-on: ubuntu-latest
     name: Stale issue job
     steps:
-    - uses: aws-actions/stale-issue-cleanup@5650b49bcd757a078f6ca06c373d7807b773f9bc #v7.1.0
+    - uses: aws-actions/stale-issue-cleanup@db44981197ae9cdada9a9c779c052439f9d62eac #v7.1.0
       with:
         issue-types: issues # only look at issues (ignore pull-requests)
 
diff --git a/provider-ci/test-providers/kubernetes-ingress-nginx/.github/workflows/comment-on-stale-issues.yml b/provider-ci/test-providers/kubernetes-ingress-nginx/.github/workflows/comment-on-stale-issues.yml
@@ -9,7 +9,7 @@ jobs:
     runs-on: ubuntu-latest
     name: Stale issue job
     steps:
-    - uses: aws-actions/stale-issue-cleanup@5650b49bcd757a078f6ca06c373d7807b773f9bc #v7.1.0
+    - uses: aws-actions/stale-issue-cleanup@db44981197ae9cdada9a9c779c052439f9d62eac #v7.1.0
       with:
         issue-types: issues # only look at issues (ignore pull-requests)
 
diff --git a/provider-ci/test-providers/kubernetes/.github/workflows/comment-on-stale-issues.yml b/provider-ci/test-providers/kubernetes/.github/workflows/comment-on-stale-issues.yml
@@ -9,7 +9,7 @@ jobs:
     runs-on: ubuntu-latest
     name: Stale issue job
     steps:
-    - uses: aws-actions/stale-issue-cleanup@5650b49bcd757a078f6ca06c373d7807b773f9bc #v7.1.0
+    - uses: aws-actions/stale-issue-cleanup@db44981197ae9cdada9a9c779c052439f9d62eac #v7.1.0
       with:
         issue-types: issues # only look at issues (ignore pull-requests)
 
diff --git a/provider-ci/test-providers/pulumi-provider-boilerplate/.github/workflows/comment-on-stale-issues.yml b/provider-ci/test-providers/pulumi-provider-boilerplate/.github/workflows/comment-on-stale-issues.yml
@@ -9,7 +9,7 @@ jobs:
     runs-on: ubuntu-latest
     name: Stale issue job
     steps:
-    - uses: aws-actions/stale-issue-cleanup@5650b49bcd757a078f6ca06c373d7807b773f9bc #v7.1.0
+    - uses: aws-actions/stale-issue-cleanup@db44981197ae9cdada9a9c779c052439f9d62eac #v7.1.0
       with:
         issue-types: issues # only look at issues (ignore pull-requests)
 
diff --git a/provider-ci/test-providers/xyz/.github/workflows/comment-on-stale-issues.yml b/provider-ci/test-providers/xyz/.github/workflows/comment-on-stale-issues.yml
@@ -9,7 +9,7 @@ jobs:
     runs-on: ubuntu-latest
     name: Stale issue job
     steps:
-    - uses: aws-actions/stale-issue-cleanup@5650b49bcd757a078f6ca06c373d7807b773f9bc #v7.1.0
+    - uses: aws-actions/stale-issue-cleanup@db44981197ae9cdada9a9c779c052439f9d62eac #v7.1.0
       with:
         issue-types: issues # only look at issues (ignore pull-requests)
 

Original file line number	Diff line number	Diff line change
`@@ -65,8 +65,8 @@ func (maintainGolangciConfig) Migrate(_ string, cwd string) error {`
`65`	`65`	`output, err := cmd.CombinedOutput()`
`66`	`66`
`67`	`67`	`if err != nil {`
`68`		`- fmt.Println(string(output))`
`69`		`- return fmt.Errorf("problem migrating golangci-lint config: %w", err)`
	`68`	`+ fmt.Printf("Problem migrating golangci-lint config:\n%s\n%s\n", err, string(output))`
	`69`	`+ return nil`
`70`	`70`	`}`
`71`	`71`
`72`	`72`	`// Cleanup the backup config if all went well.`