Skip to content

Commit f7b9223

Browse files
hmaarrfkalmarklein
andauthored
Fix compatibility with rendercanvas 2.4.0 (#768)
* Fix compatibility with rendercanvas 2.4.0 I think there might be more places but now my application runs again * use context where it makes sense --------- Co-authored-by: Almar Klein <almar@almarklein.org>
1 parent 9fe7777 commit f7b9223

File tree

3 files changed

+7
-10
lines changed

3 files changed

+7
-10
lines changed

examples/imgui_backend_sea.py

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -341,11 +341,8 @@ def gui(app_state):
341341
# init imgui backend
342342
imgui.create_context()
343343
imgui_backend = ImguiWgpuBackend(device, render_texture_format)
344-
imgui_backend.io.display_size = canvas.get_logical_size()
345-
imgui_backend.io.display_framebuffer_scale = (
346-
canvas.get_pixel_ratio(),
347-
canvas.get_pixel_ratio(),
348-
)
344+
imgui_backend.io.display_size = present_context.logical_size
345+
imgui_backend.io.display_framebuffer_scale = (present_context.pixel_ratio,) * 2
349346

350347

351348
# register event handlers

pyproject.toml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@ tests = [
3030
"imageio",
3131
"anyio",
3232
"trio",
33-
"rendercanvas",
33+
"rendercanvas>=2.4.0",
3434
]
3535
examples = ["pypng", "rendercanvas", "glfw"]
3636
docs = ["sphinx>7.2", "sphinx_rtd_theme"]

wgpu/utils/imgui/imgui_renderer.py

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -91,8 +91,8 @@ def __init__(self, device, canvas, render_target_format=None):
9191

9292
self._backend = ImguiWgpuBackend(device, render_target_format)
9393

94-
self._backend.io.display_size = canvas.get_logical_size()
95-
scale = canvas.get_pixel_ratio()
94+
self._backend.io.display_size = self._canvas_context.logical_size
95+
scale = self._canvas_context.pixel_ratio
9696
self._backend.io.display_framebuffer_scale = (scale, scale)
9797

9898
canvas.add_event_handler(self._on_resize, "resize")
@@ -144,8 +144,8 @@ def render(self):
144144

145145
imgui.set_current_context(self.imgui_context)
146146

147-
pixel_ratio = self._canvas_context.canvas.get_pixel_ratio()
148-
lsize = self._canvas_context.canvas.get_logical_size()
147+
pixel_ratio = self._canvas_context.pixel_ratio
148+
lsize = self._canvas_context.logical_size
149149
self._backend.io.display_framebuffer_scale = (pixel_ratio, pixel_ratio)
150150
self._backend.io.display_size = lsize
151151

0 commit comments

Comments
 (0)