Fixed #143 - AccessTimingParameter bad handling of timing_record

Author: pylessard

test/client/test_access_timing_parameters.py

@@ -48,12 +48,12 @@ def test_set_params_success(self):
     def _test_set_params_success(self):
         self.udsclient.set_timing_parameters(params=b"\x11\x22\x33\x44")
 
-    def test_set_params_success(self):
+    def test_set_params_success_default(self):
         request = self.conn.touserqueue.get(timeout=0.2)
         self.assertEqual(request, b"\x83\x02")
         self.conn.fromuserqueue.put(b"\xC3\x02")	# Positive response
 
-    def _test_set_params_success(self):
+    def _test_set_params_success_default(self):
         self.udsclient.reset_default_timing_parameters()
 
     def test_set_params_denied_exception(self):

test/client/test_request_file_transfer.py

@@ -288,19 +288,19 @@ def _test_replace_file_zerolen_length(self):
         with self.assertRaises(InvalidResponseException):
             self.udsclient.replace_file("my_file.txt", filesize = 0x100)
 
-    def test_replace_file_negative_response(self):
+    def test_replace_file_zerolen_length_negative_response(self):
         self.conn.touserqueue.get(timeout=0.2)
         self.conn.fromuserqueue.put(b"\x7F\x38\x22")    # Condition not correct
 
-    def _test_replace_file_negative_response(self):
+    def _test_replace_file_zerolen_length_negative_response(self):
         with self.assertRaises(NegativeResponseException):
             self.udsclient.replace_file("my_file.txt", filesize=0x100)
 
-    def test_replace_file_negative_response_no_exception(self):
+    def test_replace_file_zerolen_length_negative_response_no_exception(self):
         self.conn.touserqueue.get(timeout=0.2)
         self.conn.fromuserqueue.put(b"\x7F\x38\x22")    # Condition not correct
 
-    def _test_replace_file_negative_response_no_exception(self):
+    def _test_replace_file_zerolen_length_negative_response_no_exception(self):
         self.udsclient.config['exception_on_negative_response'] = False
         response = self.udsclient.replace_file("my_file.txt", filesize=0x100)
         self.assertTrue(response.valid)

udsoncan/client.py

@@ -666,7 +666,7 @@ def set_timing_parameters(self, params):
         :rtype: :ref:`Response<Response>`
 
         """
-        return self.access_timing_parameter(access_type=services.AccessTimingParameter.AccessType.setTimingParametersToGivenValues, request_record=params)
+        return self.access_timing_parameter(access_type=services.AccessTimingParameter.AccessType.setTimingParametersToGivenValues, timing_param_record=params)
 
 
     @standard_error_management

udsoncan/services/AccessTimingParameter.py

@@ -46,7 +46,7 @@ def make_request(cls, access_type, timing_param_record=None):
         if timing_param_record is None and access_type == cls.AccessType.setTimingParametersToGivenValues :
             raise ValueError('A timing_param_record must be provided when access_type is "setTimingParametersToGivenValues"')
 
-        request = Request(service=cls, subfunction=access_type)
+        request = Request(service=cls, subfunction=access_type, data=bytes())
 
         if timing_param_record is not None:
             if not isinstance(timing_param_record, bytes):