Skip to content

Commit 86e1943

Browse files
Pierre-SassoulasPierre-Sassoulas
committed
[logging-too-many-args] Change confidence to HIGH
1 parent e938c17 commit 86e1943

File tree

6 files changed

+28
-27
lines changed

6 files changed

+28
-27
lines changed

‎pylint/checkers/logging.py‎

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,7 @@
1616
from pylint import checkers
1717
from pylint.checkers import utils
1818
from pylint.checkers.utils import infer_all
19+
from pylint.interfaces import HIGH
1920
from pylint.typing import MessageDefinitionTuple
2021

2122
if TYPE_CHECKING:
@@ -369,7 +370,7 @@ def _check_format_string(self, node: nodes.Call, format_arg: Literal[0, 1]) -> N
369370
self.add_message("logging-format-truncated", node=node)
370371
return
371372
if num_args > required_num_args:
372-
self.add_message("logging-too-many-args", node=node)
373+
self.add_message("logging-too-many-args", node=node, confidence=HIGH)
373374
elif num_args < required_num_args:
374375
self.add_message("logging-too-few-args", node=node)
375376

‎tests/functional/l/logging/logging_too_many_args_new_style.txt‎

Lines changed: 11 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,11 @@
1-
logging-too-many-args:5:0:5:38::Too many arguments for logging format string:UNDEFINED
2-
logging-too-many-args:6:0:6:25::Too many arguments for logging format string:UNDEFINED
3-
logging-too-many-args:7:0:7:26::Too many arguments for logging format string:UNDEFINED
4-
logging-too-many-args:8:0:8:48::Too many arguments for logging format string:UNDEFINED
5-
logging-too-many-args:9:0:9:49::Too many arguments for logging format string:UNDEFINED
6-
logging-too-many-args:13:0:13:38::Too many arguments for logging format string:UNDEFINED
7-
logging-too-many-args:14:0:14:25::Too many arguments for logging format string:UNDEFINED
8-
logging-too-many-args:15:0:15:25::Too many arguments for logging format string:UNDEFINED
9-
logging-too-many-args:16:0:16:48::Too many arguments for logging format string:UNDEFINED
10-
logging-too-many-args:17:0:17:48::Too many arguments for logging format string:UNDEFINED
11-
logging-too-many-args:20:0:20:50::Too many arguments for logging format string:UNDEFINED
1+
logging-too-many-args:5:0:5:38::Too many arguments for logging format string:HIGH
2+
logging-too-many-args:6:0:6:25::Too many arguments for logging format string:HIGH
3+
logging-too-many-args:7:0:7:26::Too many arguments for logging format string:HIGH
4+
logging-too-many-args:8:0:8:48::Too many arguments for logging format string:HIGH
5+
logging-too-many-args:9:0:9:49::Too many arguments for logging format string:HIGH
6+
logging-too-many-args:13:0:13:38::Too many arguments for logging format string:HIGH
7+
logging-too-many-args:14:0:14:25::Too many arguments for logging format string:HIGH
8+
logging-too-many-args:15:0:15:25::Too many arguments for logging format string:HIGH
9+
logging-too-many-args:16:0:16:48::Too many arguments for logging format string:HIGH
10+
logging-too-many-args:17:0:17:48::Too many arguments for logging format string:HIGH
11+
logging-too-many-args:20:0:20:50::Too many arguments for logging format string:HIGH

‎tests/functional/l/logging/logging_too_many_args_old_style.txt‎

Lines changed: 11 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,11 @@
1-
logging-too-many-args:5:0:5:38::Too many arguments for logging format string:UNDEFINED
2-
logging-too-many-args:6:0:6:25::Too many arguments for logging format string:UNDEFINED
3-
logging-too-many-args:7:0:7:26::Too many arguments for logging format string:UNDEFINED
4-
logging-too-many-args:8:0:8:48::Too many arguments for logging format string:UNDEFINED
5-
logging-too-many-args:9:0:9:49::Too many arguments for logging format string:UNDEFINED
6-
logging-too-many-args:12:0:12:54::Too many arguments for logging format string:UNDEFINED
7-
logging-too-many-args:14:0:14:38::Too many arguments for logging format string:UNDEFINED
8-
logging-too-many-args:15:0:15:25::Too many arguments for logging format string:UNDEFINED
9-
logging-too-many-args:16:0:16:25::Too many arguments for logging format string:UNDEFINED
10-
logging-too-many-args:17:0:17:48::Too many arguments for logging format string:UNDEFINED
11-
logging-too-many-args:18:0:18:48::Too many arguments for logging format string:UNDEFINED
1+
logging-too-many-args:5:0:5:38::Too many arguments for logging format string:HIGH
2+
logging-too-many-args:6:0:6:25::Too many arguments for logging format string:HIGH
3+
logging-too-many-args:7:0:7:26::Too many arguments for logging format string:HIGH
4+
logging-too-many-args:8:0:8:48::Too many arguments for logging format string:HIGH
5+
logging-too-many-args:9:0:9:49::Too many arguments for logging format string:HIGH
6+
logging-too-many-args:12:0:12:54::Too many arguments for logging format string:HIGH
7+
logging-too-many-args:14:0:14:38::Too many arguments for logging format string:HIGH
8+
logging-too-many-args:15:0:15:25::Too many arguments for logging format string:HIGH
9+
logging-too-many-args:16:0:16:25::Too many arguments for logging format string:HIGH
10+
logging-too-many-args:17:0:17:48::Too many arguments for logging format string:HIGH
11+
logging-too-many-args:18:0:18:48::Too many arguments for logging format string:HIGH

‎tests/functional/r/regression/regression_9074_refactor_loop_with_unary_variable.txt‎

Whitespace-only changes.

‎tests/functional/s/string/string_formatting.txt‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@ too-few-format-args:96:4:96:25:pprint_bad:Not enough arguments for format string
3030
too-few-format-args:97:4:97:26:pprint_bad:Not enough arguments for format string:UNDEFINED
3131
too-many-format-args:98:4:98:32:pprint_bad:Too many arguments for format string:UNDEFINED
3232
logging-too-few-args:99:4:99:30:pprint_bad:Not enough arguments for logging format string:UNDEFINED
33-
logging-too-many-args:100:4:100:31:pprint_bad:Too many arguments for logging format string:UNDEFINED
33+
logging-too-many-args:100:4:100:31:pprint_bad:Too many arguments for logging format string:HIGH
3434
format-string-without-interpolation:101:4:101:22:pprint_bad:Using formatting for a string that does not have any interpolated variables:UNDEFINED
3535
format-string-without-interpolation:102:4:102:23:pprint_bad:Using formatting for a string that does not have any interpolated variables:UNDEFINED
3636
format-string-without-interpolation:103:4:103:23:pprint_bad:Using formatting for a string that does not have any interpolated variables:UNDEFINED

‎tests/functional/s/string/string_log_formatting.txt‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
1-
logging-too-many-args:14:4:14:23:pprint:Too many arguments for logging format string:UNDEFINED
2-
logging-too-many-args:15:4:15:24:pprint:Too many arguments for logging format string:UNDEFINED
1+
logging-too-many-args:14:4:14:23:pprint:Too many arguments for logging format string:HIGH
2+
logging-too-many-args:15:4:15:24:pprint:Too many arguments for logging format string:HIGH
33
logging-format-truncated:16:4:16:27:pprint:Logging format string ends in middle of conversion specifier:UNDEFINED
44
logging-too-few-args:17:4:17:28:pprint:Not enough arguments for logging format string:UNDEFINED
55
logging-unsupported-format:18:4:18:32:pprint:Unsupported logging format character 'y' (0x79) at index 3:UNDEFINED
6-
logging-too-many-args:19:4:19:36:pprint:Too many arguments for logging format string:UNDEFINED
6+
logging-too-many-args:19:4:19:36:pprint:Too many arguments for logging format string:HIGH

0 commit comments

Comments
 (0)